Skip to content

ci: delete unused add-remove-label-check-suites workflow#35450

Merged
jfversluis merged 1 commit into
dotnet:mainfrom
arpitjain099:chore/declare-workflow-perms
May 19, 2026
Merged

ci: delete unused add-remove-label-check-suites workflow#35450
jfversluis merged 1 commit into
dotnet:mainfrom
arpitjain099:chore/declare-workflow-perms

Conversation

@arpitjain099

@arpitjain099 arpitjain099 commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Per @PureWeen's review on the original PR, this workflow is no longer in use. Replacing the permissions-block edit with a straight deletion.

No functional change beyond removing the unused trigger.

@github-actions

github-actions Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35450

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35450"

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label May 14, 2026
@dotnet-policy-service

dotnet-policy-service Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Hey there @@arpitjain099! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

PureWeen
PureWeen requested changes May 14, 2026
View reviewed changes

@PureWeen PureWeen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT we aren't using this workflow anymore

Can you update this PR to just delete it?

This was referenced May 15, 2026
Open
Closed
@PureWeen PureWeen added area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging t/housekeeping ♻︎ labels May 15, 2026
@github-actions github-actions Bot mentioned this pull request May 15, 2026
Merged
@PureWeen PureWeen added area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions t/enhancement ☀️ New feature or request and removed area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging labels May 15, 2026
@arpitjain099
Delete unused add-remove-label-check-suites workflow
743a4ea 
Per @PureWeen's review on #35450, this workflow is no longer in use.
Replacing the original 'declare permissions' change with a straight
deletion.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@arpitjain099

arpitjain099 commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Hi @PureWeen, force-pushed the branch: the PR now just deletes .github/workflows/add-remove-label-check-suites.yml rather than adding a permissions: block to it. Updated the title too. Thanks for the cleanup nudge.

@arpitjain099 arpitjain099 force-pushed the chore/declare-workflow-perms branch from 32b1eb7 to 743a4ea Compare May 15, 2026 23:54
@arpitjain099 arpitjain099 changed the title ci: declare pull-requests:write on label-check-suites workflow ci: delete unused add-remove-label-check-suites workflow May 15, 2026
@github-actions github-actions Bot mentioned this pull request May 16, 2026
Closed
PureWeen added a commit that referenced this pull request May 17, 2026
@PureWeen
Address adversarial PR review findings (3/3 + 2/3 consensus)
c27ea64 
Three findings from a multi-model adversarial review (claude-opus-4.6 +
claude-sonnet-4.6 + gpt-5.3-codex with disputed-finding follow-ups):

1. **(3/3) Broken eval: 'Tooling area - CI workflow changes'**
   The scenario at lines 69-77 asserted `area-tooling` for PR #35450, but
   PR #35450 only deletes `.github/workflows/add-remove-label-check-suites.yml`
   and its real applied label is `area-infrastructure`. The previous commit
   added a rule that explicitly says workflow-only PRs should get
   `area-infrastructure` (not `area-tooling`), making this eval scenario
   contradict the very rule it was supposed to validate. Renamed to
   'Infrastructure area - CI workflow file deletion' and updated the
   assertions to expect `area-infrastructure` and NOT `area-tooling`.

2. **(2/3) Noop regex matched too loosely**
   The patterns at lines 100 and 181 included bare `skip` and bare
   `no action`, which would match agent commentary like 'applied
   area-infrastructure. This requires no action from the maintainer.' —
   producing a false-positive noop signal even when the agent applied
   labels. Replaced bare `skip` → `skip.+label` (line 181 only — line
   100 already had this) and bare `no action` →
   `no.+action.+(needed|required|appropriate|necessary)` on both lines.
   Verified against 5 legitimate noop phrasings and 2 false-positive
   scenarios: the tightened patterns reject the false positives while
   still matching all legitimate noop output.

3. **(2/3) 'touching only' qualifier ambiguous for mixed PRs**
   The `area-infrastructure` rule said 'PRs touching only ... infra
   files → area-infrastructure', which didn't address PRs that mix infra
   and product-code changes. An empirical check showed ~17% of recent
   PRs in dotnet/maui mix infra+src paths, but `area-infrastructure` is
   currently applied sparingly (mostly to infra-primary work, not every
   PR that touches an infra file). Added a tiebreaker: if the PR is
   dominated by infra changes with incidental product edits, apply
   `area-infrastructure` alongside any relevant product area label; if
   the product change is the focus and infra is incidental, prefer the
   product area label and omit `area-infrastructure`.

Discarded findings (low confidence after consensus rounds):
- Token-in-.git/config persistence (security): gh-aw framework concern,
  not introduced by this PR; cleanup runs before the agent executes;
  agent token is read-only scoped.
- Hardcoded PR/issue numbers in evals: known eval-design trade-off.
- `output_not_contains: 'platform/'` brittle: substring is acceptable
  given that all platform/* labels share the prefix.
- Dependency-bump noop timing edge case: rule is correct as stated.
- Missing iOS/Windows handler subdirectory patterns: existing extension
  patterns cover them in practice.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@arpitjain099

arpitjain099 commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@arpitjain099

arpitjain099 commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

@PureWeen I deleted the workflow as asked

This was referenced May 18, 2026
Closed
Closed
Closed
@kubaflo

kubaflo commented May 19, 2026

Copy link
Copy Markdown
Contributor

@jfversluis can you merge this?

@jfversluis jfversluis merged commit dbe9ddf into dotnet:main May 19, 2026
3 of 4 checks passed
@github-actions github-actions Bot added this to the .NET 10.0 SR8 milestone May 19, 2026
This was referenced May 20, 2026
Closed
Merged
This was referenced May 21, 2026
Open
Closed
Merged
Draft
Open
This was referenced May 30, 2026
Open
Merged
devanathan-vaithiyanathan pushed a commit to devanathan-vaithiyanathan/maui that referenced this pull request Jun 1, 2026
@arpitjain099 @devanathan-vaithiyanathan
ci: delete unused add-remove-label-check-suites workflow (dotnet#35450)
f6a7af5 
Per @PureWeen's review on the original PR, this workflow is no longer in
use. Replacing the permissions-block edit with a straight deletion.

No functional change beyond removing the unused trigger.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@github-actions github-actions Bot mentioned this pull request Jun 1, 2026
Open
4 tasks
devanathan-vaithiyanathan pushed a commit to devanathan-vaithiyanathan/maui that referenced this pull request Jun 5, 2026
@arpitjain099 @devanathan-vaithiyanathan
ci: delete unused add-remove-label-check-suites workflow (dotnet#35450)
1785664 
Per @PureWeen's review on the original PR, this workflow is no longer in
use. Replacing the permissions-block edit with a straight deletion.

No functional change beyond removing the unused trigger.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This was referenced Jun 5, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PureWeen PureWeen PureWeen requested changes

@jfversluis jfversluis jfversluis approved these changes

@kubaflo kubaflo kubaflo approved these changes

Assignees

No one assigned

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions community ✨ Community Contribution t/enhancement ☀️ New feature or request t/housekeeping ♻︎

Projects

None yet

Milestone

.NET 10 SR8

Development

Successfully merging this pull request may close these issues.

4 participants

@arpitjain099 @kubaflo @jfversluis @PureWeen