Skip to content

[Testing] Fixed Build error on inflight/ candidate PR 35234#35241

Merged
sheiksyedm merged 1 commit into
dotnet:inflight/candidatefrom
HarishKumarSF4517:harish_build_fix01
Apr 30, 2026
Merged

[Testing] Fixed Build error on inflight/ candidate PR 35234#35241
sheiksyedm merged 1 commit into
dotnet:inflight/candidatefrom
HarishKumarSF4517:harish_build_fix01

Conversation

@HarishKumarSF4517

Copy link
Copy Markdown
Contributor

This pull request removes the manual test case and its associated UI test for issue #34671, which verified that ScrollView offsets are preserved when changing orientation to Neither. The removal suggests that the issue has been resolved, the test is no longer needed, or the coverage is now handled elsewhere. Additionally, it re-enables a previously skipped assertion in another test file.

Test cleanup and re-enabling:

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Apr 30, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Apr 30, 2026
@Ahamed-Ali Ahamed-Ali added the area-testing Unit tests, device tests label Apr 30, 2026
@sheiksyedm sheiksyedm marked this pull request as ready for review April 30, 2026 07:16
@sheiksyedm sheiksyedm merged commit faf4d2f into dotnet:inflight/candidate Apr 30, 2026
2 of 11 checks passed
@github-actions github-actions Bot added this to the .NET 10 SR7 milestone Apr 30, 2026
github-actions Bot pushed a commit that referenced this pull request May 25, 2026
This pull request removes the manual test case and its associated UI
test for issue #34671, which verified that ScrollView offsets are
preserved when changing orientation to Neither. The removal suggests
that the issue has been resolved, the test is no longer needed, or the
coverage is now handled elsewhere. Additionally, it re-enables a
previously skipped assertion in another test file.

Test cleanup and re-enabling:

* Removed the manual test implementation for issue #34671 from
`TestCases.HostApp/Issues/Issue34671.cs`, including all related UI and
logic code.
* Deleted the corresponding automated UI test for issue #34671 from
`TestCases.Shared.Tests/Tests/Issues/Issue34671.cs`.
* Re-enabled the test assertion in `Issue34583.cs` by removing the
conditional compilation block that previously excluded it on Windows,
ensuring the test now runs on all platforms.
[[1]](diffhunk://#diff-bb4a07aa87e93964afe6fa53bfc2b85365586ec0f12e43b815f52d483d8bd336L1)
[[2]](diffhunk://#diff-bb4a07aa87e93964afe6fa53bfc2b85365586ec0f12e43b815f52d483d8bd336L44)
@github-actions github-actions Bot locked and limited conversation to collaborators May 30, 2026
@PureWeen PureWeen modified the milestones: .NET 10 SR7, .NET 10 SR8 Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants