[Testing] Fixed Build error on inflight/ candidate PR 35234#35241
Merged
sheiksyedm merged 1 commit intoApr 30, 2026
Merged
Conversation
Contributor
|
Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
github-actions Bot
pushed a commit
that referenced
this pull request
May 25, 2026
This pull request removes the manual test case and its associated UI test for issue #34671, which verified that ScrollView offsets are preserved when changing orientation to Neither. The removal suggests that the issue has been resolved, the test is no longer needed, or the coverage is now handled elsewhere. Additionally, it re-enables a previously skipped assertion in another test file. Test cleanup and re-enabling: * Removed the manual test implementation for issue #34671 from `TestCases.HostApp/Issues/Issue34671.cs`, including all related UI and logic code. * Deleted the corresponding automated UI test for issue #34671 from `TestCases.Shared.Tests/Tests/Issues/Issue34671.cs`. * Re-enabled the test assertion in `Issue34583.cs` by removing the conditional compilation block that previously excluded it on Windows, ensuring the test now runs on all platforms. [[1]](diffhunk://#diff-bb4a07aa87e93964afe6fa53bfc2b85365586ec0f12e43b815f52d483d8bd336L1) [[2]](diffhunk://#diff-bb4a07aa87e93964afe6fa53bfc2b85365586ec0f12e43b815f52d483d8bd336L44)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the manual test case and its associated UI test for issue #34671, which verified that ScrollView offsets are preserved when changing orientation to Neither. The removal suggests that the issue has been resolved, the test is no longer needed, or the coverage is now handled elsewhere. Additionally, it re-enables a previously skipped assertion in another test file.
Test cleanup and re-enabling:
TestCases.HostApp/Issues/Issue34671.cs, including all related UI and logic code.TestCases.Shared.Tests/Tests/Issues/Issue34671.cs.Issue34583.csby removing the conditional compilation block that previously excluded it on Windows, ensuring the test now runs on all platforms. [1] [2]