[Android] Fix DatePicker dialog dismisses after the device is rotated

[HarishwaranVijayakumar]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

• The DatePicker dialog is dismissed when the device is rotated while the dialog is open.

Root Cause of the issue

• PR 29323 added DismissEvent subscription in CreateDatePickerDialog() and an OnDialogDismiss → HidePickerDialog() chain that sets IsOpen = false.
• On rotation, OnMainDisplayInfoChanged unsubscribes DismissEvent and calls Dismiss().
• ShowPickerDialog() runs synchronously after Dismiss(), enters the else branch, and re-subscribes DismissEvent on the same dialog.
• The DismissEvent from step 2 fires after re-subscription, triggering HidePickerDialog() which dismisses the newly-shown dialog.
• Before PR 29323: There was no DismissEvent subscription, no IsOpen property, and no OnDialogDismiss handler — so the dismiss-and-re-show flow in OnMainDisplayInfoChanged worked without interference.

Description of Change

Dialog lifecycle and event handling improvements:

• Renamed ResetDialog() to DestroyDialog() and updated all references accordingly to clarify its purpose and ensure consistent dialog destruction and recreation.
• Removed unnecessary subscriptions and unsubscriptions to the dialog's DismissEvent, simplifying dialog event handling in both ShowPickerDialog() and HidePickerDialog().

Display info change handling:

• Improved the logic in OnMainDisplayInfoChanged to properly destroy and recreate the dialog with the current date, ensuring the dialog updates correctly when display information changes (such as orientation changes).

Issues Fixed

Fixes #34973

Tested the behaviour in the following platforms

• - Windows
• - Android
• - iOS
• - Mac

Before	After
Before_fixdatepicker.mov	After_fixdatepicker.mov

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34980

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34980"

[dotnet-policy-service]

Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[Copilot]

Pull request overview

Fixes an Android regression where the DatePicker dialog immediately dismisses after device rotation by adjusting the dialog lifecycle to avoid re-triggering the dialog’s dismiss handling during the rotation re-show flow.

Changes:

• Renamed ResetDialog() to DestroyDialog() and updated call sites to better reflect behavior (dismiss + null-out).
• Simplified DismissEvent wiring by removing per-show/per-hide subscribe/unsubscribe and keeping it scoped to dialog creation/destruction.
• Updated OnMainDisplayInfoChanged to capture the currently selected date, destroy the existing dialog, and recreate/show a new dialog with the captured date.

[kubaflo]

/azp run maui-pr-uitests , maui-pr-devicetests

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[kubaflo]

/review -b feature/regression-check -p android

[kubaflo]

/review -b feature/regression-check -p android

[kubaflo]

/review -b feature/regression-check -p android

[kubaflo]

/review -b feature/regression-check -p android