Skip to content

Remove the TrimmerRootAssembly workaround from Controls targets (net11.0)#34519

Draft
Copilot wants to merge 9 commits into
net11.0from
copilot/target-net110-for-pull-34503
Draft

Remove the TrimmerRootAssembly workaround from Controls targets (net11.0)#34519
Copilot wants to merge 9 commits into
net11.0from
copilot/target-net110-for-pull-34503

Conversation

Copilot AI commented Mar 17, 2026

Copy link
Copy Markdown
Contributor
  • Merge origin/net11.0 into our branch
  • Remove the _MauiFixTrimmerRootAssemblyMetadata workaround target from Microsoft.Maui.Controls.targets
  • Remove RootMode="All" from TrimmerRootAssembly items in AOTTemplateTest.cs

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits March 17, 2026 21:21
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
@github-actions

github-actions Bot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34519

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34519"

@kubaflo

kubaflo commented May 24, 2026

Copy link
Copy Markdown
Contributor

/review -b feature/refactor-copilot-yml

@MauiBot

MauiBot commented May 24, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Merge Conflict Detected — This PR has merge conflicts with its target branch. Please rebase onto the target branch and resolve the conflicts.

@kubaflo

kubaflo commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

AI code review for net11.0 target

Verdict: Needs discussion (draft)

Independent review of the diff at the PR head (not a checkout). Non-approval, automated review comment — human approval still required.

Findings:

  • Removes the _MauiFixTrimmerRootAssemblyMetadata workaround target that papered over the Android SDK MSB4096 issue (MSB4096 with user-defined TrimmerRootAssembly android#10758) when user-defined TrimmerRootAssembly items lack RootMode.
  • Safety depends on the upstream Android SDK fix having actually flowed into the Android SDK this branch consumes. CI Android/AOT integration legs are green, but those may not exercise the exact failing scenario (a user-declared TrimmerRootAssembly without RootMode). Recommend confirming the SDK fix is present in the pinned SDK version before merge.
  • Description/checklist mentions removing RootMode="All" from AOTTemplateTest.cs, but that change is not in the PR diff (only Microsoft.Maui.Controls.targets is changed). Please reconcile the description with the diff.

CI: Green.

Confidence: Medium — the change is a one-line removal; the risk is entirely about whether the upstream SDK fix has shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants