Skip to content

Improve Animation class documentation and constructors#34435

Closed
melgoharyme wants to merge 1 commit into
dotnet:mainfrom
melgoharyme:patch-1
Closed

Improve Animation class documentation and constructors#34435
melgoharyme wants to merge 1 commit into
dotnet:mainfrom
melgoharyme:patch-1

Conversation

@melgoharyme

Copy link
Copy Markdown

Description of Change

This PR improves the Animation class without changing its behavior:

  • Added missing XML docs for public/protected members (Pause(), Resume(), RemoveFromParent(), Dispose(), IsDisposed).
  • Added a constructor to create an Animation from a list of child animations.
  • Preserved existing APIs to avoid breaking changes.

These updates make the class easier to use, extend, and maintain.

Updated the Animation class to enhance documentation and functionality, including constructors for child animations and improved methods for managing animation state.
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34435

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34435"

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Mar 11, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@melgoharyme! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo

kubaflo commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Hi @melgoharyme, thanks for your interest in contributing to .NET MAUI!

After reviewing this PR, I have a few concerns:
The constructor Animation(List animations) already exists — it's present in the current code, so this isn't a new addition.

XML docs were already comprehensive — every public/protected member was already documented. The changes here rephrase them but don't add coverage for previously undocumented members.

Behavioral regression in CreateAutoReversing() — the original code intentionally sets Repeats = false on the child animation after transferring the flag to the parent. Removing that line changes runtime behavior and could cause double-repeat issues.

The diff is mostly reformatting — the +332/−376 line change is almost entirely whitespace and style changes, which makes the PR hard to review and risks unnecessary merge conflicts.

I'm closing this for now. As a general guideline, we look for PRs that address a specific bug, add a missing feature, or fix a gap backed by an issue — pure refactors and doc rephrasing without a clear motivation tend to add risk without adding value.

If you'd like to contribute, I'd encourage you to look at open issues for bugs or feature requests to work on. That way your effort goes toward something with clear impact. Happy to help point you in the right direction!

@kubaflo kubaflo closed this Mar 11, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants