Improve Animation class documentation and constructors#34435
Improve Animation class documentation and constructors#34435melgoharyme wants to merge 1 commit into
Conversation
Updated the Animation class to enhance documentation and functionality, including constructors for child animations and improved methods for managing animation state.
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34435Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34435" |
|
Hey there @@melgoharyme! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Hi @melgoharyme, thanks for your interest in contributing to .NET MAUI! After reviewing this PR, I have a few concerns: XML docs were already comprehensive — every public/protected member was already documented. The changes here rephrase them but don't add coverage for previously undocumented members. Behavioral regression in CreateAutoReversing() — the original code intentionally sets Repeats = false on the child animation after transferring the flag to the parent. Removing that line changes runtime behavior and could cause double-repeat issues. The diff is mostly reformatting — the +332/−376 line change is almost entirely whitespace and style changes, which makes the PR hard to review and risks unnecessary merge conflicts. I'm closing this for now. As a general guideline, we look for PRs that address a specific bug, add a missing feature, or fix a gap backed by an issue — pure refactors and doc rephrasing without a clear motivation tend to add risk without adding value. If you'd like to contribute, I'd encourage you to look at open issues for bugs or feature requests to work on. That way your effort goes toward something with clear impact. Happy to help point you in the right direction! |
Description of Change
This PR improves the
Animationclass without changing its behavior:Pause(),Resume(),RemoveFromParent(),Dispose(),IsDisposed).Animationfrom a list of child animations.These updates make the class easier to use, extend, and maintain.