Skip to content

[WIP] Implement lazy/trimmable styles for XAML Source Generation#34011

Merged
simonrozsival merged 2 commits into
dev/simonrozsival/trimmable-stylesfrom
copilot/sub-pr-33561
Feb 13, 2026
Merged

[WIP] Implement lazy/trimmable styles for XAML Source Generation#34011
simonrozsival merged 2 commits into
dev/simonrozsival/trimmable-stylesfrom
copilot/sub-pr-33561

Conversation

Copilot AI commented Feb 12, 2026

Copy link
Copy Markdown
Contributor
  • Extract the 25 changed files from original PR branch
  • Apply them to net11.0 base
  • Fix null safety issues from code review
    • Add null check for Type.FullName in TargetTypeFullName
    • Add null check for BaseType in CanBeAppliedTo loop
  • Verify changes compile
  • Run unit tests

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@simonrozsival

Copy link
Copy Markdown
Member

@copilot try again

- Add null check for Type.FullName in TargetTypeFullName property (can be null for generic types)
- Add null check for BaseType in CanBeAppliedTo loop to prevent NullReferenceException

These fixes address potential null reference exceptions identified in code review.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Copilot AI commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot try again

Done! Applied the null safety fixes to Style.cs as requested in commit 5cc9c1b:

✅ Added null check for Type.FullName in TargetTypeFullName property (can be null for generic types)
✅ Added null check for BaseType in CanBeAppliedTo loop to prevent NullReferenceException

The changes address the potential null reference exceptions that were identified in the code review.

@simonrozsival simonrozsival marked this pull request as ready for review February 13, 2026 07:58
@simonrozsival simonrozsival merged commit 3536086 into dev/simonrozsival/trimmable-styles Feb 13, 2026
2 of 3 checks passed
@simonrozsival simonrozsival deleted the copilot/sub-pr-33561 branch February 13, 2026 07:58
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants