Skip to content

Annotated remaining Converter classes for nullability #30573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 2 commits into from
Jul 16, 2025
Merged

Annotated remaining Converter classes for nullability #30573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34ad890
nullable enabled
NirmalKumarYuvaraj Jul 10, 2025
0c38f1a
refactoring changes
NirmalKumarYuvaraj Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/Core/src/Converters/EasingTypeConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,30 @@
using System.Globalization;
using static Microsoft.Maui.Easing;

#nullable disable

namespace Microsoft.Maui.Converters
{
/// <inheritdoc/>
public class EasingTypeConverter : TypeConverter
{
public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
=> sourceType == typeof(string) || sourceType == typeof(Func<double, double>);

public override bool CanConvertTo(ITypeDescriptorContext context, Type destinationType)
public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destinationType)
=> destinationType == typeof(string);

public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)
{
if (value is null)
{
return null;
}

var strValue = value as string ?? value.ToString();

if (string.IsNullOrWhiteSpace(strValue))
{
return null;
}

var parts = strValue.Split('.');
if (parts.Length == 2 && Compare(parts[0], nameof(Easing)))
Expand All @@ -50,10 +52,12 @@ static bool Compare(string left, string right) =>
left.Equals(right, StringComparison.OrdinalIgnoreCase);
}

public override object ConvertTo(ITypeDescriptorContext context, CultureInfo culture, object value, Type destinationType)
public override object? ConvertTo(ITypeDescriptorContext? context, CultureInfo? culture, object? value, Type destinationType)
{
if (value is not Easing easing)
{
throw new NotSupportedException();
}

return easing switch
{
Expand All @@ -72,13 +76,13 @@ _ when easing.Equals(SpringOut) => nameof(SpringOut),
};
}

public override bool GetStandardValuesSupported(ITypeDescriptorContext context)
public override bool GetStandardValuesSupported(ITypeDescriptorContext? context)
=> true;

public override bool GetStandardValuesExclusive(ITypeDescriptorContext context)
public override bool GetStandardValuesExclusive(ITypeDescriptorContext? context)
=> false;

public override StandardValuesCollection GetStandardValues(ITypeDescriptorContext context)
public override StandardValuesCollection? GetStandardValues(ITypeDescriptorContext? context)
=> new(new[] {
"Linear",
"SinOut",
Expand Down
Loading
Loading