Skip to content

[net10.0] Revert trimming workaround net10#30570

Open
rmarinho wants to merge 24 commits into
mainfrom
revert-workaround-net10
Open

[net10.0] Revert trimming workaround net10#30570
rmarinho wants to merge 24 commits into
mainfrom
revert-workaround-net10

Conversation

@rmarinho

Copy link
Copy Markdown
Member

Description of Change

When moving to net10.0 we disable some trimming warnings for iOS, will try enable them again.

@rmarinho rmarinho requested review from Copilot and rolfbjarne July 11, 2025 11:04
@rmarinho rmarinho requested a review from a team as a code owner July 11, 2025 11:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Reverts the temporary trimming analyzer workaround in the netstandard2.0 build targets so that trimming warnings are once again enabled.

  • Removed the conditional <PropertyGroup> that disabled the trim analyzer and suppressed related warnings.
  • Restored default trimming analyzer behavior for non-AOT, non-full-trim, non-explicit-suppression scenarios.
Comments suppressed due to low confidence (1)

@rmarinho rmarinho added this to the .NET 10.0-preview7 milestone Jul 11, 2025
@rmarinho rmarinho added the perf/app-size Application Size / Trimming (sub: perf) label Jul 11, 2025
rolfbjarne
rolfbjarne previously approved these changes Jul 11, 2025
@rmarinho

Copy link
Copy Markdown
Member Author

@rolfbjarne seems still lots of warnings on the sample apps , device tests etc.. is there anything else other than ignore the warnings ?

@rolfbjarne

Copy link
Copy Markdown
Member

@rmarinho do you have a binlog with some of the warnings? no relevant test seems to show up as failing here: https://dev.azure.com/xamarin/public/_build/results?buildId=146082&view=ms.vss-test-web.build-test-results-tab&runId=4521190&resultId=100038&paneView=debug

@rmarinho

rmarinho commented Oct 7, 2025

Copy link
Copy Markdown
Member Author

/rebase

@github-actions github-actions Bot force-pushed the revert-workaround-net10 branch from 537cd6e to 1515955 Compare October 7, 2025 13:04
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Oct 10, 2025
@rmarinho

Copy link
Copy Markdown
Member Author

/rebase

@github-actions github-actions Bot force-pushed the revert-workaround-net10 branch from 1515955 to 61863a7 Compare October 22, 2025 12:40
@rmarinho rmarinho modified the milestones: .NET 10.0 GA, .NET 10 SR1 Oct 22, 2025
@PureWeen PureWeen removed this from the .NET 10 SR1 milestone Nov 4, 2025

@kubaflo kubaflo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please resolve conflicts?

@kubaflo

kubaflo commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

/review -b feature/enhanced-reviewer -p ios

@kubaflo

kubaflo commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

/review rerun

@kubaflo

kubaflo commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

/review -b feature/enhanced-reviewer -p android

@github-actions github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Jun 13, 2026
@MauiBot

MauiBot commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Merge Conflict Detected — This PR has merge conflicts with its target branch. Please rebase onto the target branch and resolve the conflicts.

@MauiBot MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Jun 13, 2026
@kubaflo

kubaflo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

/review rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf/app-size Application Size / Trimming (sub: perf) s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review)

Projects

Status: Changes Requested

Development

Successfully merging this pull request may close these issues.

6 participants