[Testing] Feature matrix UITest Cases for Border Control by HarishKumarSF4517 · Pull Request #29746 · dotnet/maui

HarishKumarSF4517 · 2025-05-30T11:01:30Z

Description

This pull request introduces a new feature matrix for the Border control in the Maui.Controls.Sample project. It includes updates to the UI, view model, and test cases to support the feature matrix. The feature matrix enables detailed testing of properties like Stroke, StrokeThickness, StrokeShape, Shadow, and dynamic content.

FeatureMatrix : Border Control

Added a new entry for BorderControlPage in the gallery navigation to integrate the new feature into the application.
Created BorderControlsPage.xaml to define the layout and bindings for the main border control page. This includes a Border element with customizable properties such as stroke, padding, shadow, and content.
Added BorderOptionsPage.xaml to provide a UI for configuring border properties like stroke thickness, dash array, shadow, and content options.
Implemented BorderControlPage and BorderControlMainPage classes to manage navigation and bind the view model to the main page. Added event handlers for setting grid and stack layouts as content
Developed OptionsPage class to handle user input for border configuration, including stroke color, shape, shadow, and line cap/line join options. Added validation and event handling for user interactions
Added tests in BorderFeatureMatrixTests.cs to validate default values, property updates, and visual rendering of Border control properties across platforms.

Identified Issue:

Screen.Recording.2025-05-30.at.4.41.00.PM.mov

jsuarezruiz · 2025-05-30T11:14:27Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-30T11:14:39Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR introduces a new Border feature matrix in the Maui.Controls.Sample app, including a view model, two pages for configuring and displaying border properties, and a new navigation entry.

Adds BorderViewModel with bindable border properties and content selectors
Implements BorderControlMainPage and OptionsPage for live configuration of stroke, padding, shadow, etc.
Registers the feature in the gallery and adds initial tests in the HostApp

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

File	Description
src/Controls/tests/TestCases.HostApp/FeatureMatrix/Border/BorderViewModel.cs	Implements all border properties and content update methods
src/Controls/tests/TestCases.HostApp/FeatureMatrix/Border/BorderOptionsPage.xaml(.cs)	UI for editing border settings and event handlers
src/Controls/tests/TestCases.HostApp/FeatureMatrix/Border/BorderControlsPage.xaml(.cs)	Main page with `Border` bound to the view model and navigation logic
src/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.cs	Adds the “Border Feature Matrix” entry to the app navigation

Comments suppressed due to low confidence (3)

src/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.cs:81

You've registered the new Border feature matrix in the HostApp, but there’s no corresponding shared automated test in TestCases.Shared.Tests. Please add a test case to cover the new UI flow and ensure it runs against the HostApp.

new GalleryPageFactory(() => new BorderControlPage(), "Border Feature Matrix"),

src/Controls/tests/TestCases.HostApp/FeatureMatrix/Border/BorderOptionsPage.xaml.cs:7

[nitpick] The file is named BorderOptionsPage.xaml.cs but the class is OptionsPage. Consider renaming the class to BorderOptionsPage (or vice versa) to keep names consistent and clear.

public partial class OptionsPage : ContentPage

src/Controls/tests/TestCases.HostApp/FeatureMatrix/Border/BorderOptionsPage.xaml.cs:46

Assigning a Color to a Brush property may not work. Wrap the selected color in a SolidColorBrush, for example: _viewModel.Stroke = new SolidColorBrush(button.BackgroundColor);.

_viewModel.Stroke = button.BackgroundColor;

Copilot · 2025-05-30T12:41:45Z

+
+	private void OnSetGridContentClicked(object sender, EventArgs e)
+	{
+		var grid = new Grid


The grid is instantiated but never applied to the Border or ViewModel. You should assign it (e.g., _viewModel.ContentView = grid;) so the UI actually updates when the button is clicked.

Removed the event handler and updated the corresponding changes.

Copilot · 2025-05-30T12:41:45Z

+
+	private void OnSetStackContentClicked(object sender, EventArgs e)
+	{
+		var stack = new VerticalStackLayout


The stack layout is created but not used. Consider assigning it to the ViewModel (e.g., _viewModel.ContentView = stack;) or directly to the Border so it appears in the UI.

Removed the event handler and updated the corresponding changes.

jsuarezruiz

Pending snapshots already available in the latest build.

Could you commit the images?

HarishKumarSF4517 · 2025-05-30T18:01:25Z

Pending snapshots already available in the latest build.

Could you commit the images?

Hi @jsuarezruiz, I have attached the required Snapshots

jsuarezruiz · 2025-06-02T06:26:04Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-02T06:26:15Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-06-03T09:10:53Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-03T09:11:05Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

I think is not related with the PR, but the test NullPointerExceptionOnFastLabelTextColorChange is failing on iOS and Cataluyst because a crash.
The app was expected to be running still, investigate as possible crash

jsuarezruiz · 2025-06-10T06:29:56Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-10T06:30:08Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Some tests are failing on Windows:

Example:
Border_StrokeColorWithStrokeThickness
Snapshot different than baseline: Border_StrokeColorWithStrokeThickness.png (5.05% difference)

Could you review it?

HarishKumarSF4517 · 2025-06-10T13:22:51Z

Hi @jsuarezruiz,
I have checked and addressed the failed test cases and committed the changes. Can you review and share your concerns?

PureWeen · 2025-07-15T20:39:46Z

/azp run

azure-pipelines · 2025-07-15T20:40:09Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-09-02T05:55:07Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-02T05:55:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Some Windows reference snapshots requires an update:

Snapshot different than baseline: Border_Shadow.png (size differs - baseline is 1010x729 pixels, actual is 1010x661 pixels)

jsuarezruiz · 2025-09-04T06:45:02Z

/rebase

jsuarezruiz · 2025-09-04T06:45:53Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-04T06:46:04Z

Azure Pipelines successfully started running 1 pipeline(s).

* harish_feature_matrix_border * Update BorderFeatureTests.cs * Updated BorderFeatureTest.cs * Update BorderFeatureTests.cs * Added Shapes for Border Control * Updated the TestCases * Added Snapshots * Updated the SnapShots * Added Fails to the Testcase * Update BorderFeatureTests.cs * Update BorderFeatureTests.cs * Updated the Windows Snapshots

dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 30, 2025

ghost added the area-testing Unit tests, device tests label May 30, 2025

HarishKumarSF4517 marked this pull request as ready for review May 30, 2025 12:38

Copilot AI review requested due to automatic review settings May 30, 2025 12:38

HarishKumarSF4517 requested a review from a team as a code owner May 30, 2025 12:38

HarishKumarSF4517 requested review from PureWeen and jsuarezruiz May 30, 2025 12:38

Copilot AI reviewed May 30, 2025

View reviewed changes

jsuarezruiz suggested changes May 30, 2025

View reviewed changes

rmarinho changed the base branch from main to inflight/current May 30, 2025 18:56

ghost requested a review from jsuarezruiz May 31, 2025 11:04

github-actions Bot force-pushed the inflight/current branch from f5a279d to c33253a Compare June 2, 2025 17:32

jsuarezruiz reviewed Jun 4, 2025

View reviewed changes

github-actions Bot force-pushed the inflight/current branch 3 times, most recently from 24dd756 to 0423cbb Compare June 7, 2025 13:18

jsuarezruiz suggested changes Jun 10, 2025

View reviewed changes

HarishKumarSF4517 mentioned this pull request Jun 10, 2025

StrokeDashArray on Border does not reset when set to null #29898

Open

github-actions Bot force-pushed the inflight/current branch from 42ca2bd to b5a6090 Compare June 10, 2025 16:43

ghost requested a review from jsuarezruiz August 19, 2025 05:47

jsuarezruiz suggested changes Sep 2, 2025

View reviewed changes

HarishKumarSF4517 added 12 commits September 4, 2025 06:45

harish_feature_matrix_border

cd33c83

Update BorderFeatureTests.cs

301dfec

Updated BorderFeatureTest.cs

b41adec

Update BorderFeatureTests.cs

b826eeb

Added Shapes for Border Control

05ddd9b

Updated the TestCases

205d688

Added Snapshots

f69d0e0

Updated the SnapShots

3a023d2

Added Fails to the Testcase

501e13e

Update BorderFeatureTests.cs

d2c1727

Update BorderFeatureTests.cs

85fef0f

Updated the Windows Snapshots

9b4f732

jsuarezruiz approved these changes Sep 9, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current September 11, 2025 15:47

PureWeen merged commit 2e9d2c3 into dotnet:inflight/current Sep 11, 2025
78 checks passed

github-actions Bot locked and limited conversation to collaborators Oct 12, 2025

Conversation

HarishKumarSF4517 commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

FeatureMatrix : Border Control

Uh oh!

jsuarezruiz commented May 30, 2025

Uh oh!

azure-pipelines Bot commented May 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

HarishKumarSF4517 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

HarishKumarSF4517 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

HarishKumarSF4517 commented May 30, 2025

Uh oh!

jsuarezruiz commented Jun 2, 2025

Uh oh!

azure-pipelines Bot commented Jun 2, 2025

Uh oh!

jsuarezruiz commented Jun 3, 2025

Uh oh!

azure-pipelines Bot commented Jun 3, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jun 10, 2025

Uh oh!

azure-pipelines Bot commented Jun 10, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

HarishKumarSF4517 commented Jun 10, 2025

Uh oh!

PureWeen commented Jul 15, 2025

Uh oh!

azure-pipelines Bot commented Jul 15, 2025

Uh oh!

jsuarezruiz commented Sep 2, 2025

Uh oh!

azure-pipelines Bot commented Sep 2, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Sep 4, 2025

Uh oh!

jsuarezruiz commented Sep 4, 2025

Uh oh!

azure-pipelines Bot commented Sep 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HarishKumarSF4517 commented May 30, 2025 •

edited

Loading