Skip to content

Fix for border color of the RadioButton is visible in Windows#28214

Merged
rmarinho merged 7 commits into
dotnet:mainfrom
SyedAbdulAzeemSF4852:fix-28153
Mar 25, 2025
Merged

Fix for border color of the RadioButton is visible in Windows#28214
rmarinho merged 7 commits into
dotnet:mainfrom
SyedAbdulAzeemSF4852:fix-28153

Conversation

@SyedAbdulAzeemSF4852

@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Issue Details

  • The border color of the radiobutton is visible only in windows.

Root Cause

  • If the stroke thickness is not explicitly set, a default Thickness object with a value of 3 is created, causing the border to be visible.

Description of Change

  • If the stroke thickness is not explicitly set, then created a default thickness object with a value of 0.

Validated the behaviour in the following platforms

  • Windows

  • Android

  • iOS

  • Mac

Issues Fixed

Fixes #28153

Output

Before Fix After Fix

Other Platforms Output

Android iOS Mac

@dotnet-policy-service dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Mar 6, 2025
@SyedAbdulAzeemSF4852

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree company="Syncfusion, Inc."

@jsuarezruiz jsuarezruiz added the area-controls-radiobutton RadioButton, RadioButtonGroup label Mar 6, 2025
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

{
AutomationId = "RadioButton",
Content = "RadioButton",
BorderColor = Colors.Red

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include two radioButtons, one of them using the StrokeThickness property to validate all the scenarios with a single snapshot.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz , I have modified the test case. Please let me know if you have any concerns.

@jsuarezruiz jsuarezruiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, with the changes needs to review and update some failing tests:
image

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28153.cs Outdated
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 marked this pull request as ready for review March 11, 2025 11:00
@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 requested a review from a team as a code owner March 11, 2025 11:00

@jsuarezruiz jsuarezruiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two tests keeps failing on Windows:
image

Small differences on both cases in the snapshots. Could you take a look?

@SyedAbdulAzeemSF4852

Copy link
Copy Markdown
Contributor Author

These two tests keeps failing on Windows: image

Small differences on both cases in the snapshots. Could you take a look?

@jsuarezruiz , I've reviewed the snapshots and have committed the latest snapshots.

@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz jsuarezruiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test ValidateRadioButtonNoBorderColorWhenNoBorderWidth is failing on Android, iOS, Mac.

On iOS:
Snapshot different than baseline: ValidateRadioButtonNoBorderColorWhenNoBorderWidth.png (3.44% difference)

This is the result:
image

@SyedAbdulAzeemSF4852

Copy link
Copy Markdown
Contributor Author

@jsuarezruiz , I have committed the latest snapshots.

@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 43fd3fa into dotnet:main Mar 25, 2025
@rmarinho rmarinho added this to the .NET 9 SR6 milestone Mar 25, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-radiobutton RadioButton, RadioButtonGroup community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The border color of the RadioButton is visible in Windows only

5 participants