Skip to content

Fixed ScrollView Orientation Neither issue#27231

Merged
PureWeen merged 8 commits into
dotnet:inflight/currentfrom
Vignesh-SF3580:fix-18418
Mar 24, 2025
Merged

Fixed ScrollView Orientation Neither issue#27231
PureWeen merged 8 commits into
dotnet:inflight/currentfrom
Vignesh-SF3580:fix-18418

Conversation

@Vignesh-SF3580

@Vignesh-SF3580 Vignesh-SF3580 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Issue Detail

Scrolling remains enabled in a ScrollView, even when Orientation is Neither.

Root Cause

The implementation does not correctly disable scrolling or adjust scrollbar visibility when ScrollOrientation is set to Neither.

Description of Change

Added logic to disable both horizontal and vertical scrolling, when ScrollOrientation is set to Neither.

Tested the behavior in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed

Fixes #18418
Fixes #27140

Screenshots

Before Issue Fix After Issue Fix
iOSBefore.mov
iOSAfter.mov

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Jan 20, 2025
@dotnet-policy-service

dotnet-policy-service Bot commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 20, 2025
@jsuarezruiz

jsuarezruiz commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 20, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@Vignesh-SF3580 Vignesh-SF3580 marked this pull request as ready for review January 21, 2025 10:57
Copilot AI review requested due to automatic review settings January 21, 2025 10:57
@Vignesh-SF3580 Vignesh-SF3580 requested a review from a team as a code owner January 21, 2025 10:57
Copilot AI reviewed Jan 21, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/Core/src/PublicAPI/net-windows/PublicAPI.Shipped.txt: Language not supported
  • src/Core/src/Handlers/ScrollView/ScrollViewHandler.Windows.cs: Evaluated as low risk

@jsuarezruiz

jsuarezruiz commented Jan 27, 2025 •
edited by jfversluis
Loading

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

This comment was marked as outdated.

Sign in to view
jfversluis
jfversluis reviewed Feb 25, 2025
View reviewed changes

@jfversluis jfversluis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think technically not really a breaking change, but lets not risk it

Comment thread src/Core/src/Platform/Windows/ScrollViewerExtensions.cs Outdated
Comment thread src/Core/src/PublicAPI/net-windows/PublicAPI.Shipped.txt Outdated
jfversluis
jfversluis reviewed Feb 25, 2025
View reviewed changes

@jfversluis jfversluis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, need to rename the references to this too of course

Comment thread src/Core/src/Platform/Windows/ScrollViewerExtensions.cs Outdated
Comment thread src/Core/src/Platform/Windows/ScrollViewerExtensions.cs Outdated
Comment thread src/Core/src/Platform/Windows/ScrollViewerExtensions.cs Outdated
@MartyIX MartyIX mentioned this pull request Mar 8, 2025
Merged
@rmarinho rmarinho added this to the .NET 9 SR6 milestone Mar 20, 2025
@rmarinho rmarinho moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 20, 2025
@dotnet dotnet deleted a comment from jsuarezruiz Mar 20, 2025
@dotnet dotnet deleted a comment from azure-pipelines Bot Mar 20, 2025
@rmarinho rmarinho requested review from jfversluis and jsuarezruiz and removed request for StephaneDelcroix and tj-devel709 March 20, 2025 19:14
@rmarinho

rmarinho commented Mar 21, 2025

Copy link
Copy Markdown
Member

/rebase

@Vignesh-SF3580 Vignesh-SF3580 changed the base branch from main to inflight/current March 21, 2025 13:37
@PureWeen PureWeen moved this from Ready To Review to Approved in MAUI SDK Ongoing Mar 24, 2025
@PureWeen PureWeen merged commit 2dd0c47 into dotnet:inflight/current Mar 24, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Done in MAUI SDK Ongoing Mar 24, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR6, .NET 9 SR7 Mar 24, 2025
PureWeen pushed a commit that referenced this pull request Mar 26, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
1735317 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
PureWeen pushed a commit that referenced this pull request Mar 28, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
7885aa3 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
github-actions Bot pushed a commit that referenced this pull request Apr 2, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
d2bc71f 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
@Vignesh-SF3580 Vignesh-SF3580 mentioned this pull request Apr 3, 2025
Merged
github-actions Bot pushed a commit that referenced this pull request Apr 3, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
b2986ff 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
github-actions Bot pushed a commit that referenced this pull request Apr 8, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
625a2d0 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
@Vignesh-SF3580 Vignesh-SF3580 mentioned this pull request Apr 9, 2025
Merged
bhavanesh2001 pushed a commit to bhavanesh2001/maui that referenced this pull request Apr 11, 2025
@Vignesh-SF3580 @jfversluis @bhavanesh2001
Fixed ScrollView Orientation Neither issue (dotnet#27231)
7074b5c 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
PureWeen pushed a commit that referenced this pull request Apr 11, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
11ac640 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
github-actions Bot pushed a commit that referenced this pull request Apr 11, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
1541630 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
github-actions Bot pushed a commit that referenced this pull request Apr 14, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
52f6aef 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
github-actions Bot pushed a commit that referenced this pull request Apr 15, 2025
@Vignesh-SF3580 @jfversluis @PureWeen
Fixed ScrollView Orientation Neither issue (#27231)
ef98fa4 
* Fixed - 18418 : ScrollView Orientation=Neither not working

* updated ScrollViewerExtensions.cs

* Disable the scroll in ios when orientation is neither.

* updated ScrollViewHandler.iOS.cs

* testcases updated.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Gerald Versluis <gerald@verslu.is>
@PureWeen PureWeen mentioned this pull request Apr 16, 2025
Merged
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@rmarinho rmarinho rmarinho approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees

No one assigned

Labels

area-controls-scrollview ScrollView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR7

Development

Successfully merging this pull request may close these issues.

ScrollView Remains Scrollable Despite ScrollOrientation.Neither Setting on Windows Platform [Android] ScrollView Orientation=Neither not working

7 participants

@Vignesh-SF3580 @jsuarezruiz @rmarinho @jfversluis @PureWeen @karthikraja-arumugam