Skip to content

Radio button's default template improvements #26719

Merged
PureWeen merged 3 commits into
dotnet:mainfrom
kubaflo:fix-26689
Jan 29, 2025
Merged

Radio button's default template improvements #26719
PureWeen merged 3 commits into
dotnet:mainfrom
kubaflo:fix-26689

Conversation

@kubaflo

@kubaflo kubaflo commented Dec 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issues Fixed

Fixes #26689

<RadioButton
    Content="wwa"
    BackgroundColor="Red"
    HeightRequest="50"
    Margin="0,70,0,0"
    TextColor="Black"/>
Before After

@kubaflo kubaflo requested a review from a team as a code owner December 19, 2024 01:22
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Dec 19, 2024
@PureWeen PureWeen added this to the .NET 9 SR4 milestone Dec 20, 2024
@PureWeen

PureWeen commented Dec 20, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 20, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz

jsuarezruiz commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

/azp run

@jsuarezruiz jsuarezruiz self-assigned this Jan 15, 2025
@azure-pipelines

azure-pipelines Bot commented Jan 15, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

mattleibow
mattleibow previously approved these changes Jan 15, 2025
View reviewed changes
PureWeen
PureWeen requested changes Jan 15, 2025
View reviewed changes

@PureWeen PureWeen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unit tests are failing

Border Style properties should not affect RadioButton(property: BindableProperty { DeclaringType = typeof(Microsoft.Maui.Controls.VisualElement), DefaultBindingMode = OneWay, DefaultValue = 0, IsReadOnly = False, PropertyName = "Rotation", ... }, value: 0.

@kubaflo kubaflo force-pushed the fix-26689 branch 2 times, most recently from dbe1b8e to 93130f4 Compare January 17, 2025 16:12
@kubaflo

kubaflo commented Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

The changes required unit tests adjustments

@jsuarezruiz

jsuarezruiz commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

/rebase

@jsuarezruiz

jsuarezruiz commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 21, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit 5d50806 into dotnet:main Jan 29, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PureWeen PureWeen PureWeen approved these changes

@mattleibow mattleibow mattleibow left review comments

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@jsuarezruiz jsuarezruiz

Labels

area-controls-radiobutton RadioButton, RadioButtonGroup community ✨ Community Contribution platform/android platform/ios platform/windows

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR4

Development

Successfully merging this pull request may close these issues.

Radiobutton not visible in .Net Maui on iOS 18

4 participants

@kubaflo @PureWeen @jsuarezruiz @mattleibow