Shadows & Gradients don't work with a list view's header/footer - fix#26637
Merged
Conversation
kubaflo
requested review from
a team,
jfversluis and
jsuarezruiz
as code owners
Contributor
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/android
platform/ios
area-controls-listview
Member
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Dec 16, 2024
rmarinho
requested changes
Dec 16, 2024
rmarinho
left a comment
rmarinho
left a comment
Member
There was a problem hiding this comment.
Test seem to be failing on Android
Contributor
Author
Is this test related to these changes? |
rmarinho
approved these changes
Dec 16, 2024
rmarinho
left a comment
rmarinho
left a comment
Member
There was a problem hiding this comment.
Yeah I double check and these test failed in main also randomly . So this os good to go
rmarinho
approved these changes
Dec 16, 2024
Contributor
Author
This should help: #26657 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Replaced
.PlatformViewwith.ToPlatform()to respect awrapperViewIssues Fixed
Fixes #26636