Skip to content

[Android] BackgroundColor for GraphicsView#26320

Merged
jfversluis merged 1 commit into
dotnet:inflight/currentfrom
kubaflo:fix-19568
Aug 12, 2025
Merged

[Android] BackgroundColor for GraphicsView#26320
jfversluis merged 1 commit into
dotnet:inflight/currentfrom
kubaflo:fix-19568

Conversation

@kubaflo

@kubaflo kubaflo commented Dec 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issues Fixed

Fixes #19568

Before After

@kubaflo kubaflo requested a review from a team as a code owner December 3, 2024 01:38
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Dec 3, 2024
@dotnet-policy-service

dotnet-policy-service Bot commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution and removed community ✨ Community Contribution labels Dec 3, 2024
@rmarinho

rmarinho commented Dec 3, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 3, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

mattleibow
mattleibow reviewed Dec 4, 2024
View reviewed changes

@mattleibow mattleibow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, just wondering why this is just on android and also what should a "null" color be?

Comment thread src/Core/src/Platform/Android/GraphicsViewExtensions.cs Outdated
@rmarinho

rmarinho commented Dec 4, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 4, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz

jsuarezruiz commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

/rebase

jsuarezruiz
jsuarezruiz suggested changes Jan 10, 2025
View reviewed changes
Comment thread src/Controls/tests/TestCases.HostApp/Issues/Issue19568.cs Outdated
{
public Issue19568()
{
Content = new GraphicsView()

@jsuarezruiz jsuarezruiz Jan 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the test a little bit?, add a Layout, and some content behind the GraphicsView. Then, add a button to add and remove the BackgroundColor to see if it works and can see/access to the element behind. Just to validate that can aadd/remove the background color at runtime.

@kubaflo kubaflo Jan 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Done, I think

@rmarinho

rmarinho commented Jan 10, 2025

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo

kubaflo commented Mar 30, 2025

Copy link
Copy Markdown
Contributor Author

I had a feeling this pr: #26368 would fix it, but it didn't

@kubaflo kubaflo self-assigned this Mar 30, 2025
@jfversluis

jfversluis commented Aug 12, 2025

Copy link
Copy Markdown
Member

/rebase

Copilot AI review requested due to automatic review settings August 12, 2025 10:09
Copilot AI reviewed Aug 12, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jfversluis jfversluis added this to the .NET 9 SR11 milestone Aug 12, 2025
@jfversluis jfversluis changed the base branch from main to inflight/current August 12, 2025 10:10
@jfversluis jfversluis merged commit cdf14c6 into dotnet:inflight/current Aug 12, 2025
1 check passed
github-actions Bot pushed a commit that referenced this pull request Aug 15, 2025
@kubaflo @PureWeen
[Android] BackgroundColor for GraphicsView (#26320)
f885538
github-actions Bot pushed a commit that referenced this pull request Aug 15, 2025
@kubaflo @PureWeen
[Android] BackgroundColor for GraphicsView (#26320)
84464ab
github-actions Bot pushed a commit that referenced this pull request Aug 19, 2025
@kubaflo @PureWeen
[Android] BackgroundColor for GraphicsView (#26320)
2bc5adb
github-actions Bot pushed a commit that referenced this pull request Aug 22, 2025
@kubaflo @PureWeen
[Android] BackgroundColor for GraphicsView (#26320)
c1bb44a
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattleibow mattleibow mattleibow left review comments

Copilot code review Copilot Copilot left review comments

@jfversluis jfversluis jfversluis approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kubaflo kubaflo

Labels

area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution platform/android

Projects

None yet

Milestone

.NET 9 SR11

Development

Successfully merging this pull request may close these issues.

GraphicsView does not change the Background/BackgroundColor on Android

6 participants

@kubaflo @rmarinho @jsuarezruiz @jfversluis @mattleibow