Skip to content

Make Style nullable#25230

Merged
jfversluis merged 4 commits into
dotnet:mainfrom
pictos:pj/fix-nullable-warning
Dec 12, 2024
Merged

Make Style nullable#25230
jfversluis merged 4 commits into
dotnet:mainfrom
pictos:pj/fix-nullable-warning

Conversation

@pictos

@pictos pictos commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

Description of Change

Add the ? symbol to the Style property of controls.

Issues Fixed

Fixes #25227

@pictos pictos requested a review from a team as a code owner October 13, 2024 01:33
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Oct 13, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

Comment thread src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
@StephaneDelcroix

Copy link
Copy Markdown
Contributor

it feels weird that among all the properties we have, not attributed as nullable, that Style is the only one to fail.

@pictos pictos requested a review from jsuarezruiz October 17, 2024 19:40
@rmarinho rmarinho changed the base branch from net9.0 to main October 19, 2024 23:51
@pictos pictos force-pushed the pj/fix-nullable-warning branch from 921c8bc to 36f08df Compare October 22, 2024 15:48
@mattleibow

Copy link
Copy Markdown
Member

I figured it out. We forgot to add the #nullable disable when we moved the style code into the new StyleableElement.

@mattleibow

Copy link
Copy Markdown
Member

/rebase

@mattleibow

mattleibow commented Dec 5, 2024

Copy link
Copy Markdown
Member

/azp run

@mattleibow mattleibow closed this Dec 5, 2024
@azure-pipelines

This comment was marked as outdated.

@mattleibow mattleibow reopened this Dec 5, 2024
mattleibow
mattleibow previously approved these changes Dec 5, 2024
@mattleibow

mattleibow commented Dec 5, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

This comment was marked as outdated.

@PureWeen PureWeen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Users/builder/azdo/_work/3/s/src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt(88,1): error RS0017: Symbol 'Microsoft.Maui.Controls.StyleableElement.Style.get -> Microsoft.Maui.Controls.Style!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]

@pictos

pictos commented Dec 7, 2024

Copy link
Copy Markdown
Contributor Author

@PureWeen I removed that entry, not sure if I understood how that API file is written, but I believe when there's a ! at the end, it indicates that value is not nullable, so I remove that line, since there's the same symbol declared there, but it's nullable

@pictos pictos requested a review from PureWeen December 7, 2024 07:41
jfversluis
jfversluis previously approved these changes Dec 9, 2024
@azure-pipelines

This comment was marked as outdated.

@jfversluis jfversluis added the area-xaml XAML, CSS, Triggers, Behaviors label Dec 9, 2024
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis added this to the .NET 9 SR3 milestone Dec 12, 2024
@jfversluis jfversluis dismissed PureWeen’s stale review December 12, 2024 09:14

Feedback was addressed

@jfversluis jfversluis merged commit 43b8bc4 into dotnet:main Dec 12, 2024
@pictos pictos deleted the pj/fix-nullable-warning branch December 13, 2024 00:22
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-xaml XAML, CSS, Triggers, Behaviors community ✨ Community Contribution fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entry.Style is Not Nullable

7 participants