Make Style nullable#25230
Conversation
|
Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
it feels weird that among all the properties we have, not attributed as nullable, that Style is the only one to fail. |
921c8bc to
36f08df
Compare
|
I figured it out. We forgot to add the |
|
/rebase |
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
PureWeen
left a comment
There was a problem hiding this comment.
/Users/builder/azdo/_work/3/s/src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt(88,1): error RS0017: Symbol 'Microsoft.Maui.Controls.StyleableElement.Style.get -> Microsoft.Maui.Controls.Style!' is part of the declared API, but is either not public or could not be found (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]
|
@PureWeen I removed that entry, not sure if I understood how that API file is written, but I believe when there's a |
This comment was marked as outdated.
This comment was marked as outdated.
af31e34 to
77ac734
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
Add the
?symbol to theStyleproperty of controls.Issues Fixed
Fixes #25227