Skip to content

Clear out prototype cell when changing ItemSource#24700

Merged
PureWeen merged 3 commits into
mainfrom
fix_20261
Sep 11, 2024
Merged

Clear out prototype cell when changing ItemSource#24700
PureWeen merged 3 commits into
mainfrom
fix_20261

Conversation

@PureWeen

Copy link
Copy Markdown
Member

Description of Change

When converting ListView over to handler architecture we incorrectly commented out the code that would reset the prototype cell when the item source changed. This now causes issues with the prototype cell being reused and the datatemplate selector is being changed out

Issues Fixed

Fixes #20261

@PureWeen PureWeen requested a review from a team as a code owner September 10, 2024 21:09
Redth
Redth previously approved these changes Sep 10, 2024
rmarinho
rmarinho previously approved these changes Sep 10, 2024
@PureWeen PureWeen dismissed stale reviews from rmarinho and Redth via 744de28 September 10, 2024 21:45
@PureWeen PureWeen changed the title Clear out prototype cell which changing ItemSource Clear out prototype cell when changing ItemSource Sep 10, 2024
@PureWeen PureWeen added this to the .NET 8 SR9 milestone Sep 11, 2024
@mattleibow mattleibow added the area-controls-listview ListView and TableView label Sep 11, 2024
Comment thread src/Controls/tests/DeviceTests/Elements/ListView/ListViewTests.cs Outdated
@PureWeen

Copy link
Copy Markdown
Member Author
  • Catalyst is currently having issues installing .NET. These tests passed on iOS so these changes are good to go as far as iOS is concerned.
  • Template tests won't be involved with these changes

@PureWeen PureWeen merged commit fd718a1 into main Sep 11, 2024
@PureWeen PureWeen deleted the fix_20261 branch September 11, 2024 23:17
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ListView + DataTemplateSelector + HasUnevenRows issue on iOS

5 participants