Conversation
PureWeen
commented
Jul 3, 2024
| // to get attached. | ||
| uiView.BeginInvokeOnMainThread(() => OnLoadedCheck(null)); | ||
| if (lifeCycleEvents is null) | ||
| uiView.BeginInvokeOnMainThread(() => OnLoadedCheck(null)); |
Member
Author
There was a problem hiding this comment.
This was only relevant when we were using Observers to try and detect loaded/unloaded changes.
If we're wiring directly to the events then we don't need to dispatch anything
|
Will this be in a .net 8 release soon? |
|
This fix is highly desirable for XF projects being converted to MAUI where the legacy soft-input behaviour is required. |
Member
Author
|
/rebase |
github-actions
Bot
force-pushed
the
fix_21681
branch
from
eda3f58 to
7d3cf37
Compare
Member
Author
|
/rebase |
github-actions
Bot
force-pushed
the
fix_21681
branch
from
7d3cf37 to
5793ddf
Compare
4 tasks
Member
Author
|
This PR is currently being worked on by @sheiksyedm on a different branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The reason that
HideSoftInputOnTappedonly works when you're nested in a NavigationPage and Shell is that both of those structures are firing theSendNavigatedto events on theContentPAgewhich is required for theHideSoftInputOnTappedwiring to take effect. This PR makes it so the root window page will now fire all of these events which thus makes theHideSoftInputOnTappedwork.I've also wired up iOS through a few additional paths for loaded/unloaded via the VC so that they will fire more reliably.
Issues Fixed
Fixes #21681