added Command and CommandParameter on CheckBox

[pictos]

Description of Change

Issues Fixed

Fixes #7394

[ghost]

Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[rmarinho]

Could we also add a simple UITest to show how it renderers check and uncheck and a Visual test.

Thanks

[pictos]

@rmarinho does maui use inline docs normally or there's some xml file that I should add?

[pictos]

Could we also add a simple UITest to show how it renderers check and uncheck and a Visual test.

@rmarinho can you point me to a UITest that I can use as sample... I tried to look into the existing one on Appium project, but couldn't figure out how to create the UI to test

[rmarinho]

@rmarinho does maui use inline docs normally or there's some xml file that I should add?

We use inline docs now. @jfversluis can help you with that if you need.

Could we also add a simple UITest to show how it renderers check and uncheck and a Visual test.

@rmarinho can you point me to a UITest that I can use as sample... I tried to look into the existing one on Appium project, but couldn't figure out how to create the UI to test

Add your UI here :
https://github.com/dotnet/maui/blob/main/src/Controls/samples/Controls.Sample.UITests/Issues/Issue19379.xaml#L2

Add your test here:
https://github.com/dotnet/maui/blob/main/src/Controls/tests/UITests/Tests/Issues/Issue19379.cs#L27

Run it one time on CI to generate the screenshots and add them here:
https://github.com/dotnet/maui/tree/main/src/Controls/tests/UITests/snapshots

[jfversluis]

does maui use inline docs normally or there's some xml file that I should add?

Yes please add the documentation inline and NOT the external XML files :)

[mattleibow]

The is looking close, but I had some questions/comments.

• Should the command and the event always fire (or not) together?
• Please add inline XML docs
• Please add some unit tests for the checkbox in the areas:
  • CheckChanged event
  • Command/CommandParameter
  • IsEnabled
• Please add some UI tests for checkbox:
  • Appears correctly in the correct state with Command CanExecute
  • Tapping the check box when enabled and disabled does the right thing

[mattleibow]

Not sure what we should be doing here as we are going to fire the CheckChanged event but NOT the command if the command disabled it.

The command can disable the checkbox, and that is fine. But, if the dev then manually sets checked and we only fire one, will that be unexpected? Do we have a place where we have an event and command and we have to do something like this?

I found Button does this:

public static void ElementClicked(VisualElement visualElement, IButtonElement ButtonElementManager)
{
	if (visualElement.IsEnabled == true)
	{
		ButtonElementManager.Command?.Execute(ButtonElementManager.CommandParameter);
		ButtonElementManager.PropagateUpClicked(); // <- this is the clicked event
	}
}

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[rmarinho]

/rebase

[rmarinho]

Needs manual rebase

[rmarinho]

Please reopen targeting the net10 branch