Throw error when pushing without wrapping into navigation page#20155
Merged
jfversluis merged 4 commits intoMar 19, 2024
Merged
Conversation
ghost
added
the
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
As discussed on this live stream this seems not the right place to do things, please let us know if anything is not clear on how to proceed to discuss further. Thank you! |
kubaflo
force-pushed
the
error-when-pushing-without-wrapping-into-navigation-page
branch
from
1156abb to
ada6251
Compare
Contributor
Author
|
@jfversluis @PureWeen I've added a commit that moves this exception to the Window class and it seems to be working fine :) |
kubaflo
force-pushed
the
error-when-pushing-without-wrapping-into-navigation-page
branch
from
ada6251 to
0b19c46
Compare
PureWeen
requested changes
Mar 15, 2024
PureWeen
approved these changes
Mar 18, 2024
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MartyIX
reviewed
Mar 19, 2024
jfversluis
approved these changes
Mar 19, 2024
Member
|
Thanks for another great contribution @kubaflo ! |
Contributor
|
🚨 API change(s) detected @davidbritch FYI |
MartyIX
added a commit
to MartyIX/maui
that referenced
this pull request
Mar 19, 2024
MartyIX
added a commit
to MartyIX/maui
that referenced
this pull request
Mar 20, 2024
rmarinho
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Make sure to await async test asserts * More * Cases introduced in #20155 * Two more --------- Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Throw error when pushing without wrapping into navigation page
Issues Fixed
Fixes #2013