Shell.OnNavigated not called for route navigation

[ArcanoxDragon]

Description

On 10.0.50 and above, the Shell.OnNavigated(ShellNavigatedEventArgs args) method is not invoked when a navigation is triggered using the Shell.Current.GoToAsync method.

In my company's app, we register a number of our pages using AddTransientWithShellRoute from CommunityToolkit.Maui (e.g. AddTransientWithShellRoute<MyPage, MyViewModel>(), which adds a route called "MyPage" for that page). Our app's shell is a subclass of Shell named AppShell.

When we need to navigate, we call await Shell.Current.GoToAsync("MyPage", ...) to navigate to the correct page. On 10.0.41, this navigation causes our AppShell class's OnNavigated method to be called once the navigation is performed. We use this to handle post-navigation events.

On 10.0.50 and above, OnNavigated is no longer called for such navigations on iOS. It works fine on Android. Our app does not target Mac Catalyst, so I am unsure if this bug also occurs there.

I have traced this to the IShellController.UpdateCurrentState implementation in Shell.cs:

maui/src/Controls/src/Core/Shell/Shell.cs

Lines 984 to 999 in 720a9d4

	void IShellController.UpdateCurrentState(ShellNavigationSource source)
	{
	var oldState = CurrentState;
	var shellItem = CurrentItem;
	var shellSection = shellItem?.CurrentItem;
	var shellContent = shellSection?.CurrentItem;
	var stack = shellSection?.Stack;
	var modalStack = shellSection?.Navigation?.ModalStack;
	var result = ShellNavigationManager.GetNavigationState(shellItem, shellSection, shellContent, stack, modalStack);
	if (result?.Location != oldState?.Location)
	{
	SetValueFromRenderer(CurrentStatePropertyKey, result);
	_navigationManager.HandleNavigated(new ShellNavigatedEventArgs(oldState, CurrentState, source));
	}
	}

After the navigation occurs, result?.Location and oldState?.Location both hold the same value (the old page), so it never calls HandleNavigated.

For example, after signing in, the app changes the shell's CurrentItem to one of the root items - suppose this item has a route of /RootItem/RootContent. The user can select an item on this root page that will result in await Shell.Current.GoToAsync("MyPage", ...).

Once this navigation occurs, UpdateCurrentState is called, and both result?.Location and oldState?.Location evaluate to /RootItem/RootContent, instead of what I would expect to see, which would be result?.Location evaluating to /MyPage.

Steps to Reproduce

• Create a simple shell app
• Add one page to the shell directly as a shell item
• Register another page with a route instead of a shell item (either using CommunityToolkit, or just by using Routing.RegisterRoute)
• Add a way for the first page (the direct shell item) to navigate to the second page (the routed page) using Shell.Current.GoToAsync
• Override OnNavigated in the shell class, and print a debug statement when it is called
• Run the app on iOS and perform the navigation. Observe that OnNavigated is not called.

Link to public reproduction project repository

No response

Version with bug

10.0.50

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

10.0.40

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

[sheiksyedm]

@ArcanoxDragon I tried to reproduce the issue based on your reproduction steps, but unfortunately, I was unable to reproduce it. Could you please share a reproduction sample to help validate this issue?

[TiicTac54]

I had a similar issue related with
"ShellNavigationManager.GetNavigationSate()"

I opened a discussion for it on the Maui discord

https://discord.com/channels/1351511037215772672/1488945749348847810

[ArcanoxDragon]

@ArcanoxDragon I tried to reproduce the issue based on your reproduction steps, but unfortunately, I was unable to reproduce it. Could you please share a reproduction sample to help validate this issue?

I haven't been successful so far in reproducing the issue in a "minimal app", and haven't had a lot of time recently to try different things to recreate it. I refactored a bit of our app's navigation code to work around the problem for now - I hope to have time over the next couple of days to try and reproduce this in a minimal project that I can upload.

[sheiksyedm]

I can reproduce the @TiicTac54 issue scenario as after GoToAsync("//DashboardPage/Page1/Page2") on iOS 10.0.50+, Shell.CurrentState.Location reports "//DashboardPage" (stale) instead of "//DashboardPage/Page1/Page2". I have attached the reproduction sample.
@TiicTac54 Can you confirm this?

shell_demo.zip