Skip to content

[runtime] Add missing release for call to mono_reflection_type_get_type.#11756

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:coreclr-fix-missing-release-call
Jun 1, 2021
Merged

[runtime] Add missing release for call to mono_reflection_type_get_type.#11756
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:coreclr-fix-missing-release-call

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

No more leaks!

Before:

There were 205834 MonoObjects created, 205834 MonoObjects freed, so no leaked MonoObjects. (static registrar)
There were 258092 MonoObjects created, 258013 MonoObjects freed, so 79 were not freed. (dynamic registrar)

After:

✅ There were 205834 MonoObjects created, 205834 MonoObjects freed, so no leaked MonoObjects. (static registrar)
✅ There were 258100 MonoObjects created, 258100 MonoObjects freed, so no leaked MonoObjects. (dynamic registrar)

No more leaks!

Before:

    There were 205834 MonoObjects created, 205834 MonoObjects freed, so no leaked MonoObjects. (static registrar)
    There were 258092 MonoObjects created, 258013 MonoObjects freed, so 79 were not freed. (dynamic registrar)

After:

    ✅ There were 205834 MonoObjects created, 205834 MonoObjects freed, so no leaked MonoObjects. (static registrar)
    ✅ There were 258100 MonoObjects created, 258100 MonoObjects freed, so no leaked MonoObjects. (dynamic registrar)
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Jun 1, 2021
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 106 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug (CoreCLR) [dotnet]: Failed (Test run failed.
    Tests run: 2444 Passed: 2356 Inconclusive: 7 Failed: 2 Ignored: 86)
  • framework-test/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 8c443c5 into 1e1e029

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failures are unrelated

@rolfbjarne rolfbjarne merged commit ebfeee6 into dotnet:main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants