Skip to content

[runtime] Don't forget to free the method field in MonoMethodSignatures.#11746

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:coreclr-free-method-in-monomethodsignature
Jun 1, 2021
Merged

[runtime] Don't forget to free the method field in MonoMethodSignatures.#11746
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:coreclr-free-method-in-monomethodsignature

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Before:

There were 258096 MonoObjects created, 246948 MonoObjects freed, so 11148 were not freed. (dynamic registrar)
There were 205834 MonoObjects created, 205214 MonoObjects freed, so 620 were not freed. (static registrar)

After:

There were 205834 MonoObjects created, 205222 MonoObjects freed, so 612 were not freed. (dynamic registrar)
There were 258100 MonoObjects created, 258019 MonoObjects freed, so 81 were not freed. (static registrar)

Before:

    There were 258096 MonoObjects created, 246948 MonoObjects freed, so 11148 were not freed. (dynamic registrar)
    There were 205834 MonoObjects created, 205214 MonoObjects freed, so 620 were not freed. (static registrar)

After:

    There were 205834 MonoObjects created, 205222 MonoObjects freed, so 612 were not freed. (dynamic registrar)
    There were 258100 MonoObjects created, 258019 MonoObjects freed, so 81 were not freed. (static registrar)
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels May 31, 2021
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 107 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug (CoreCLR) [dotnet]: Failed (Test run failed.
    Tests run: 2444 Passed: 2356 Inconclusive: 7 Failed: 2 Ignored: 86)

Pipeline on Agent XAMBOT-1100.BigSur
Merge 4af29b9 into 8d6893c

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failure is unrelated and will be fixed with #11732.

@rolfbjarne rolfbjarne merged commit 1e1e029 into dotnet:main Jun 1, 2021
@rolfbjarne rolfbjarne deleted the coreclr-free-method-in-monomethodsignature branch June 1, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants