Skip to content

Update developer-guide.md - #6870

Merged
michaelgsharp merged 1 commit into
dotnet:mainfrom
computerscienceiscool:patch-3
Dec 7, 2023
Merged

michaelgsharp merged 1 commit into
dotnet:mainfrom
computerscienceiscool:patch-3

Conversation

@computerscienceiscool

Copy link
Copy Markdown
Contributor

Fixed a couple of spelling errors

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Fixed a couple of spelling errors
@ghost ghost added the community-contribution Pull requests submitted by community contributors label Oct 20, 2023
@codecov

codecov Bot commented Oct 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6870 (38a729c) into main (766569b) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #6870      +/-   ##
==========================================
+ Coverage   69.40%   69.41%   +0.01%     
==========================================
  Files        1238     1238              
  Lines      249441   249441              
  Branches    25522    25520       -2     
==========================================
+ Hits       173130   173155      +25     
+ Misses      69692    69539     -153     
- Partials     6619     6747     +128     
Flag Coverage Δ
Debug 69.41% <60.00%> (+0.01%) ⬆️
production 63.94% <60.00%> (+0.01%) ⬆️
test 88.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Microsoft.Data.Analysis/VBufferDataFrameColumn.cs 45.77% <60.00%> (-1.41%) ⬇️

... and 15 files with indirect coverage changes

@michaelgsharp

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp michaelgsharp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@michaelgsharp

Copy link
Copy Markdown
Contributor

Merging since its just a doc fix.

@michaelgsharp
michaelgsharp merged commit 9d92597 into dotnet:main Dec 7, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Pull requests submitted by community contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants