Skip to content

fix #5767 issue with DataFrame Merge method - #5768

Merged
pgovind merged 1 commit into
dotnet:mainfrom
asmirnov82:main
Apr 29, 2021
Merged

pgovind merged 1 commit into
dotnet:mainfrom
asmirnov82:main

Conversation

@asmirnov82

@asmirnov82 asmirnov82 commented Apr 26, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #5767

Fix issue related to DataFrame Merge method with Algorithm.Inner, in case when right dataframe has more rows. that left

@dnfadmin

dnfadmin commented Apr 26, 2021 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@codecov

codecov Bot commented Apr 26, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #5768 (c527c21) into main (ebc431f) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5768      +/-   ##
==========================================
- Coverage   68.38%   68.33%   -0.06%     
==========================================
  Files        1131     1131              
  Lines      241019   241027       +8     
  Branches    25024    25026       +2     
==========================================
- Hits       164822   164699     -123     
- Misses      69714    69831     +117     
- Partials     6483     6497      +14     
Flag Coverage Δ
Debug 68.33% <100.00%> (-0.06%) ⬇️
production 62.96% <100.00%> (-0.07%) ⬇️
test 89.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.Join.cs 97.88% <100.00%> (-0.03%) ⬇️
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.94% <100.00%> (+<0.01%) ⬆️
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 83.60% <0.00%> (-7.16%) ⬇️
src/Microsoft.ML.FastTree/Training/StepSearch.cs 57.42% <0.00%> (-4.96%) ⬇️
src/Microsoft.ML.Data/Training/TrainerUtils.cs 65.86% <0.00%> (-3.82%) ⬇️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 85.49% <0.00%> (-3.08%) ⬇️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 71.42% <0.00%> (-1.37%) ⬇️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 71.96% <0.00%> (-1.16%) ⬇️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 91.46% <0.00%> (-1.03%) ⬇️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 66.83% <0.00%> (-0.52%) ⬇️
... and 4 more

@pgovind pgovind left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this LGTM!

@pgovind

pgovind commented Apr 28, 2021

Copy link
Copy Markdown

Thank you for the PR @asmirnov82 ! Really appreciate the work here!

@asmirnov82

Copy link
Copy Markdown
Contributor Author

You are welcome @pgovind. Do I need to click "Close PR" to merge it or you will merge it by yourself?

@pgovind

pgovind commented Apr 28, 2021 •

Copy link
Copy Markdown

Do I need to click "Close PR" to merge it or you will merge it by yourself?

I'm not sure how the permissions are set up in this repo. In this particular case, I'll do it because we're working on fixing the CI in this repo

@asmirnov82

Copy link
Copy Markdown
Contributor Author

Thanks!

@pgovind

pgovind commented Apr 29, 2021 •

Copy link
Copy Markdown

@asmirnov82, I believe CI is fixed in the repo now. Can you rebase your PR on the latest dotnet/main?

Edit: Never mind, I was able to do it within GitHub!

@pgovind

pgovind commented Apr 29, 2021

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@pgovind
pgovind merged commit 9ece0ff into dotnet:main Apr 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataFrame merge method change Left and Right values

3 participants