Skip to content

[Issue4484] Support specifying command timeout while using the database loader - #5288

Merged
gh-yewang merged 9 commits into
dotnet:masterfrom
gh-yewang:wangye/x
Jul 8, 2020
Merged

gh-yewang merged 9 commits into
dotnet:masterfrom
gh-yewang:wangye/x

Conversation

@gh-yewang

Copy link
Copy Markdown
Contributor

fix issue 4484

-add option to set db command timeout in db loader
-add corresponding test
this pr partially refers to a hanging PR.

@gh-yewang
gh-yewang requested a review from a team as a code owner July 6, 2020 21:18
Comment thread src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseLoaderCursor.cs Outdated
@codecov

codecov Bot commented Jul 6, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #5288 into master will decrease coverage by 4.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5288      +/-   ##
==========================================
- Coverage   73.68%   69.51%   -4.17%     
==========================================
  Files        1022      779     -243     
  Lines      190320   145811   -44509     
  Branches    20470    18576    -1894     
==========================================
- Hits       140232   101366   -38866     
+ Misses      44557    39273    -5284     
+ Partials     5531     5172     -359     
Flag Coverage Δ
#Debug 69.51% <100.00%> (-4.17%) ⬇️
#production 69.51% <100.00%> (+0.09%) ⬆️
#test ?
Impacted Files Coverage Δ
...Data/DataLoadSave/Database/DatabaseLoaderCursor.cs 23.43% <100.00%> (+0.48%) ⬆️
...ft.ML.Data/DataLoadSave/Database/DatabaseSource.cs 100.00% <100.00%> (ø)
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 79.83% <0.00%> (-6.73%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 23.78% <0.00%> (-0.98%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0.00%> (-0.85%) ⬇️
test/Microsoft.ML.TestFramework/PasteArguments.cs
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs
test/Microsoft.ML.Benchmarks/Harness/Configs.cs
.../Microsoft.ML.Tests/Transformers/NAReplaceTests.cs
....ML.Tests/Transformers/DateTimeTransformerTests.cs
... and 247 more
#Resolved

@codecov

codecov Bot commented Jul 6, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #5288 into master will increase coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #5288      +/-   ##
==========================================
+ Coverage   73.68%   73.75%   +0.07%     
==========================================
  Files        1022     1022              
  Lines      190320   190360      +40     
  Branches    20470    20472       +2     
==========================================
+ Hits       140232   140404     +172     
+ Misses      44557    44439     -118     
+ Partials     5531     5517      -14     
Flag Coverage Δ
#Debug 73.75% <75.00%> (+0.07%) ⬆️
#production 69.52% <62.50%> (+0.09%) ⬆️
#test 87.62% <81.25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...ft.ML.Data/DataLoadSave/Database/DatabaseSource.cs 83.33% <57.14%> (-16.67%) ⬇️
test/Microsoft.ML.Tests/DatabaseLoaderTests.cs 93.33% <81.25%> (-0.75%) ⬇️
...Data/DataLoadSave/Database/DatabaseLoaderCursor.cs 23.07% <100.00%> (+0.12%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <0.00%> (-3.37%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 23.78% <0.00%> (-0.98%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0.00%> (-0.85%) ⬇️
src/Microsoft.ML.FastTree/FastTreeRanking.cs 55.06% <0.00%> (-0.77%) ⬇️
src/Microsoft.ML.FastTree/FastTreeArguments.cs 85.49% <0.00%> (+0.11%) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 66.58% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Data/Prediction/Calibrator.cs 80.72% <0.00%> (+0.26%) ⬆️
... and 11 more

@gh-yewang
gh-yewang requested a review from antoniovs1029 July 7, 2020 00:13
Comment thread src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseSource.cs Outdated
Comment thread test/Microsoft.ML.Tests/DatabaseLoaderTests.cs Outdated
Comment thread src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseSource.cs Outdated
Comment thread test/Microsoft.ML.Tests/DatabaseLoaderTests.cs Outdated
@harishsk

harishsk commented Jul 7, 2020 •

Copy link
Copy Markdown
Contributor
        Contracts.CheckValue(providerFactory, nameof(providerFactory));

What is the default timeout if this constructor is used? #Resolved


Refers to: src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseSource.cs:19 in 2406db1. [](commit_id = 2406db1, deletion_comment = False)

Comment thread src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseSource.cs
@gh-yewang

gh-yewang commented Jul 7, 2020 •

Copy link
Copy Markdown
Contributor Author
        Contracts.CheckValue(providerFactory, nameof(providerFactory));

What is the default timeout if this constructor is used?

Refers to: src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseSource.cs:19 in 2406db1. [](commit_id = 2406db1, deletion_comment = False)

The default timeout is 30s #Resolved

@gh-yewang
gh-yewang marked this pull request as draft July 7, 2020 19:52
@gh-yewang
gh-yewang marked this pull request as ready for review July 7, 2020 20:37

@frank-dong-ms-zz frank-dong-ms-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseSource.cs
@gh-yewang
gh-yewang requested a review from harishsk July 7, 2020 22:04

@harishsk harishsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseSource.cs Outdated
@gh-yewang
gh-yewang merged commit a00a222 into dotnet:master Jul 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants