Skip to content

Disallow bad input types in FeatureSelection estimator's GetOutputSchema method - #4702

Merged
yaeldekel merged 1 commit into
dotnet:masterfrom
yaeldekel:featureselection
Jan 30, 2020
Merged

Disallow bad input types in FeatureSelection estimator's GetOutputSchema method#4702
yaeldekel merged 1 commit into
dotnet:masterfrom
yaeldekel:featureselection

Conversation

@yaeldekel

@yaeldekel yaeldekel commented Jan 24, 2020

Copy link
Copy Markdown

Related to #4693 .

@yaeldekel
yaeldekel requested a review from a team as a code owner January 24, 2020 15:01
@yaeldekel yaeldekel mentioned this pull request Jan 24, 2020
Closed
harishsk
harishsk approved these changes Jan 25, 2020
View reviewed changes

@harishsk harishsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yaeldekel

yaeldekel commented Jan 26, 2020

Copy link
Copy Markdown
Author 
    public void FeatureSelectionWorkout()

This test is now failing because of issue #969, so this PR should wait until PR #4696 is merged before it can be merged.

Refers to: test/Microsoft.ML.Tests/Transformers/FeatureSelectionTests.cs:27 in aae82c5. [](commit_id = aae82c5, deletion_comment = False)

@yaeldekel
yaeldekel merged commit 74917b9 into dotnet:master Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@harishsk harishsk harishsk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaeldekel @harishsk @yaeldMS