Skip to content

added in support for System.DateTime type for the DateTimeTransformer - #4661

Merged
michaelgsharp merged 3 commits into
dotnet:masterfrom
michaelgsharp:datetimetransformer-datetimetype
Jan 22, 2020
Merged

michaelgsharp merged 3 commits into
dotnet:masterfrom
michaelgsharp:datetimetransformer-datetimetype

Conversation

@michaelgsharp

Copy link
Copy Markdown
Contributor

Added in support to the DateTimeTransformer to use columns of DateTime type.

Removed the thread safe caching as its faster to just query the native code multiple times then to deal with the thread safe cache.

@michaelgsharp
michaelgsharp requested review from a team and ganik January 15, 2020 20:31
@michaelgsharp michaelgsharp self-assigned this Jan 15, 2020
@codecov

codecov Bot commented Jan 16, 2020 •

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@c4e4263). Click here to learn what that means.
The diff coverage is 95.89%.

@@            Coverage Diff            @@
##             master    #4661   +/-   ##
=========================================
  Coverage          ?   75.86%           
=========================================
  Files             ?      951           
  Lines             ?   172447           
  Branches          ?    18646           
=========================================
  Hits              ?   130834           
  Misses            ?    36444           
  Partials          ?     5169
Flag Coverage Δ
#Debug 75.86% <95.89%> (?)
#production 71.44% <92.3%> (?)
#test 90.7% <100%> (?)
Impacted Files Coverage Δ
....ML.Tests/Transformers/DateTimeTransformerTests.cs 100% <100%> (ø)
...rc/Microsoft.ML.Featurizers/DateTimeTransformer.cs 88.1% <92.3%> (ø)

Comment thread src/Microsoft.ML.Featurizers/DateTimeTransformer.cs Outdated
Comment thread test/Microsoft.ML.Tests/Transformers/DateTimeTransformerTests.cs Outdated
Comment thread src/Microsoft.ML.Featurizers/DateTimeTransformer.cs Outdated
Comment thread src/Microsoft.ML.Featurizers/DateTimeTransformer.cs
Comment thread src/Microsoft.ML.Featurizers/DateTimeTransformer.cs
Comment thread src/Microsoft.ML.Featurizers/DateTimeTransformer.cs Outdated

@harishsk harishsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Comment thread src/Microsoft.ML.Featurizers/DateTimeTransformer.cs Outdated
Comment thread src/Microsoft.ML.Featurizers/DateTimeTransformer.cs Outdated

@harishsk harishsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelgsharp

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp
michaelgsharp merged commit 681c128 into dotnet:master Jan 22, 2020
@michaelgsharp
michaelgsharp deleted the datetimetransformer-datetimetype branch January 22, 2020 20:40
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants