Skip to content

[Meta Issue] Changing defaults #4749

Description

@najeeb-kazmi

First of all, is this a breaking change? @terrajobst suggested it is an acceptable breaking change #2305 (comment), @eerhardt commented that is was decided that changing defaults is acceptable #2305 (comment)

cc: @harishsk @justinormont @gvashishtha @eerhardt

Activity

  1. najeeb-kazmi commented on Jan 31, 2020

    @najeeb-kazmi
    MemberAuthor

    Assigning @gvashishtha for triage.

  2. justinormont commented on Jan 31, 2020

    @justinormont
    Contributor

    @justinormont correct me if I am wrong: was the default weighting TF-IDF in TLC? It is currently TF

    The default text recipe in TLC uses TF. I believe the current default in ML․NET is also TF, so no changes needed for that.

  3. eerhardt commented on Jan 31, 2020

    @eerhardt
    Member

    Changing a default parameter value is an acceptable change. Just be sure you still support the old default value - for example if the old default was ‘null’ and you change it to a non-null default, you still should support ‘null’ values.

  4. self-assigned this
    on Jul 1, 2020
  5. michaelgsharp commented on Jul 10, 2020

    @michaelgsharp
    Contributor

    With the merging of PRs #5248, #5258, and #5290, this issue has been resolved. Closing this issue.

  6. ghost locked as resolved and limited conversation to collaborators on Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions