Enable error on prebuilts#18173
Merged
MichaelSimons merged 4 commits intoFeb 8, 2024
Merged
Conversation
Member
|
Blocked on dotnet/arcade#14353 flowing into installer. |
ellahathaway
force-pushed
the
enable-prebuilt-detection
branch
from
January 17, 2024 23:45
da17cf0 to
85b51be
Compare
Member
Author
|
This PR should be unblocked now. I merged in main and made the appropriate changes. |
Member
Author
|
Blocked by dotnet/source-build#3985 |
MichaelSimons
approved these changes
Feb 7, 2024
MichaelSimons
enabled auto-merge (squash)
February 7, 2024 20:29
Member
Author
Member
Member
Author
Whoops, realized that this is being discussed internally. Also appears that #18505 might be the cause. Sorry for the ping! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables errors when prebuilts are detected. This was originally disabled in 4e3e6d9.
Relates to dotnet/source-build#3665