Re-enable realsig#17104
Merged
Merged
Conversation
Contributor
|
KevinRansom
force-pushed
the
realenablerealsig
branch
2 times, most recently
from
69acf28 to
ec6f50f
Compare
KevinRansom
force-pushed
the
realenablerealsig
branch
from
ec6f50f to
02fbcbf
Compare
KevinRansom
added
the
NO_RELEASE_NOTES
Contributor
Author
|
//cc @psfinaki @vzarytovskii @T-Gro This is ready |
T-Gro
approved these changes
May 6, 2024
Contributor
|
Do I get it right that the surface area is now the same with both realsig on and off? If so, this hack should be removed. |
Contributor
Author
Removed |
psfinaki
approved these changes
May 7, 2024
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Thanks Kevin for handling this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realsig got disabled by a merge back from release/dev10.
The recent merge of the Equals() optimization identified an issue with DU codegen. There was an issue with how DU code generation worked for DU type members for realsig-. It always generates members with the scope of the DU case. The Equals() optimization applied to a public DU with internal cases was generated with an internal scope rather than public visibility.
This change: