Warning Message "The 'FSharpProjectPackage' did not load correctly"

[ricardozimmer]

Please provide a succinct description of the issue.

1. Update VS Community 2017 (Version 15.9.4) with Visual Fsharp Tools Version 15.9.2018.12.24.1 generates a few error messages. The error info ex: in activity log;

675 2018/12/26 12:58:06.973 Error VisualStudio CreateInstance failed for package [FSharpProjectPackage]Source: 'mscorlib' Description: Could not load file or assembly 'FSharp.ProjectSystem.FSharp, Version=15.9.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A) System.IO.FileLoadException: Could not load file or assembly 'FSharp.ProjectSystem.FSharp, Version=15.9.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. Strong name validation failed. (Exception from HRESULT: 0x8013141A) File name: 'FSharp.ProjectSystem.FSharp, Version=15.9.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' ---> System.Security.SecurityException: Strong name validation failed. (Exception from HRESULT: 0x8013141A) The Zone of the assembly that failed was: MyComputer at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) at System.Activator.CreateInstance(String assemblyString, String typeName, Boolean ignoreCase, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes, Evidence securityInfo, StackCrawlMark& stackMark) at System.Activator.CreateInstance(String assemblyName, String typeName) at System.AppDomain.CreateInstance(String assemblyName, String typeName) System.Security.SecurityException: Strong name validation failed. (Exception from HRESULT: 0x8013141A) The Zone of the assembly that failed was: MyComputer {91A04A73-4F2C-4E7C-AD38-C1A68E7DA05C}

---

80004005 - E_FAIL

Actual behavior

Package does not load

Known workarounds

None

Related information

• Operating system Windows 10
• .NET 4.7
• Community V 15.9.4
  ActivityLog.zip

[cartermp]

@ricardozimmer Does this repro without the nightly installed?

[TeaDrivenDev]

I get this on VS 15.9.4 and 15.9.5 on different machines only with 20181224.1. On the first start of VS after installation, F# projects cannot be loaded and F# files not opened. On subsequent VS restarts, the error messages persist, and while F# files can be opened again, there is no syntax highlighting whatsoever. Uninstalled, installed 20181217.1 again, which works without any problems immediately.

[cartermp]

It will have come from one of the following:

#5841 (unlikely)
#5985
#6046
#6040
#6039 (highly unlikely)
#6027 (highly unlikely)
#5951 (highly unlikely)

[cartermp]

cc @KevinRansom and @brettfo any ideas?

[ricardozimmer]

@cartermp Unisntalling nightly works fine.

[irium]

I also have this issue with nighties on VS 15.9.5 Pro
Works good on stock Visual F# 15.8.20181029.1

[lessismore1]

VS Enterpris 2017 (Version 15.9.6) with Visual Fsharp Tools Version 15.9 nighlty build generates a same error message. The last nightly build that works is VisualFSharp.15.8.20181217.1.

Something happend between 15.8 and 15.9 ?

[vslynko]

I have upgraded all projects in my solution from Legacy project system to the modern one. And still have same problem. The Tag on this issue might be wrong.

[KevinRansom]

@ricardozimmer

We have uncovered a signing issue that is impacting our build, @brettfo is working on fixing it. Allthough it has proved particularly resistant to fixing. Given that this error is also due to an invalidly signed assembly this may be due to the same underlying fault.

The reason we didn't catch this, is likely because we are often dogfooding unsigned previews of visual studio and in order to run those we have validation turned off.

Sorry.

[gchernis]

Looks good this AM

[gchernis]

I verified that a signed version of FSharp.ProjectSystem.FSharp.dll from \AppData\Local\Microsoft\VisualStudio\15.0_fc294f60\Extensions<Something>\FSharp.ProjectSystem.FSharp.dll is dated today, Feb 20, 2019