Using NO_TYPEPROVIDERS in FSharp.Compiler.Service.fsproj

[nojaf]

Hello,

I noticed if I add <OtherFlags>$(OtherFlags) --define:NO_TYPEPROVIDERS</OtherFlags> in FSharp.Compiler.Service.fsproj the project no longer builds.

Should NO_TYPEPROVIDERS still be a thing then?

[vzarytovskii]

Yeah, we should fix it

[nojaf]

Could you tell me when this is being used? This has probably been broken for some time now.

[vzarytovskii]

Could you tell me when this is being used? This has probably been broken for some time now.

TL;DR is that they're useful for fable

More here: #13491 (comment)

[vzarytovskii]

Update - i have the fix ready, will submit pr today

[KevinRansom]

Last time I tried to remove it @dsyme wanted it kept in. So, yes NO_TYPEPROVIDERS should work. I suppose we should add a build step to verify it as well.

Kevin

[vzarytovskii]

Last time I tried to remove it @dsyme Don Syme FTE wanted it kept in. So, yes NO_TYPEPROVIDERS should work. I suppose we should add a build step to verify it as well.

Kevin

It wasn't working, I've fixed it and building Proto compiler with NO_TYPEPROVIDERS define (since we don't need it in proto), see the PR: #14645