Repository navigation
Update to Aspire 13.6.0 - #1039
Merged
Merged
Conversation
DamianEdwards
added
the
NO-MERGE
eerhardt
reviewed
Sep 28, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
DamianEdwards
changed the title
DamianEdwards
marked this pull request as ready for review
October 1, 2026 23:08
eerhardt
approved these changes
Oct 1, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The resource migration bypasses the forwarded-header subscriber, risking incorrect redirects and authentication callbacks behind TLS-terminating proxies.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates eShop to Aspire 13.6 and migrates its AppHost to Project Resource v2.
Changes:
- Upgrades Aspire SDKs and centrally managed dependencies.
- Migrates project registrations, helper signatures, and tests to
AddDotnetProject. - Updates OpenAPI handling, generated schemas, and development settings.
| File | Description |
|---|---|
| tests/Webhooks.FunctionalTests/Webhooks.FunctionalTests.csproj | Updates SDK and enables CLI bundle. |
| tests/Ordering.FunctionalTests/Ordering.FunctionalTests.csproj | Updates SDK and enables CLI bundle. |
| tests/eShop.AppHost.UnitTests/AppHostConfigurationTests.cs | Migrates test resources to AddDotnetProject. |
| tests/Catalog.FunctionalTests/Catalog.FunctionalTests.csproj | Updates SDK and enables CLI bundle. |
| tests/Basket.FunctionalTests/Basket.FunctionalTests.csproj | Updates SDK and enables CLI bundle. |
| src/WebhookClient/Properties/launchSettings.json | Uses HTTPS schema URL. |
| src/WebApp/Properties/launchSettings.json | Uses HTTPS schema URL. |
| src/eShop.ServiceDefaults/OpenApiOptionsExtensions.cs | Updates version metadata and schema examples. |
| src/eShop.ServiceDefaults/OpenApi.Extensions.cs | Passes the supplied API version description. |
| src/eShop.AppHost/Properties/launchSettings.json | Uses HTTPS schema URL. |
| src/eShop.AppHost/Extensions.cs | Updates helper resource types. |
| src/eShop.AppHost/eShop.AppHost.csproj | Updates SDK, adds Dotnet package, removes project references. |
| src/eShop.AppHost/AppHost.cs | Migrates service and app registrations. |
| src/Catalog.API/Catalog.API.json | Represents v1 API version as an enum. |
| src/Catalog.API/Catalog.API_v2.json | Represents v2 API version as an enum. |
| Directory.Packages.props | Updates central dependency versions. |
| aspire.config.json | Pins Aspire SDK to 13.6.0. |
| .vscode/settings.json | Selects the default solution filter. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
eerhardt
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aspire.Hosting.Dotnet,Aspire.Hosting.Foundry, andAspire.Azure.AI.OpenAIuse the officially published13.6.0-preview.1.26479.8versions; the other Aspire packages and AppHost SDK use13.6.0.AddDotnetProject) and removes obsolete project references and experimental warning suppressions.launchSettings.jsonfiles.