Remove semantic versioning v1 flag from StringTools - #7653
Merged
Conversation
Fixes the broken official build due to msbuild packages using semver v2 but stringtools semver1 which causes an incompatibility when restoring.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the SemanticVersioningV1 packaging flag from the Microsoft.NET.StringTools project so its produced package aligns with SemVer v2 expectations during restore, addressing official build failures caused by a SemVer v1/v2 incompatibility.
Changes:
- Removed
<SemanticVersioningV1>true</SemanticVersioningV1>fromStringTools.csproj. - Normalized boolean casing for
GeneratePackageOnBuildtotrue(and minor whitespace adjustments).
Show a summary per file
| File | Description |
|---|---|
| src/msbuild/src/StringTools/StringTools.csproj | Drops SemVer v1 packaging flag so the produced package follows SemVer v2-compatible versioning behavior during restore. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
akoeplinger
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken official build due to msbuild packages now using semver v2 but stringtools semver1 which causes an incompatibility when restoring:
18.10.0-1-26359-122vs18.10.0-1.26359.122