Add an image to build runtime on illumos#324
Conversation
mthalman
left a comment
There was a problem hiding this comment.
Yes, the Unable to find image info data for path 'src/windowsservercore/ltsc2019/helix/amd64/Dockerfile' error is an infrastructure issue and can be ignored.
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
This should be defined as a symbolic file link not a copy of the file. This is how the other post-build references are defined - https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/master/src/ubuntu/18.04/cross/arm64-alpine/hooks/post-build
There was a problem hiding this comment.
I just followed how it was done for FreeBSD: https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/772abb5ae3b7d57d9ed26313c2f5de1f6d330ca8/src/ubuntu/18.04/cross/freebsd/12/hooks/post-build (also v11).
There was a problem hiding this comment.
I see - I guess that means there are multiple places that are incorrect.
The image is built using illumos sysroot from dotnet/arcade, to build products from dotnet/runtime repo.
Also optimized the dotnet/arcade clone command to make it fetch
depth=1for one branch (instead of all branches).Contributes to dotnet/runtime#34944.