Add missing xml docs for System.Runtime.Intrinsics#11930
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds and enriches missing XML documentation for System.Runtime.Intrinsics vector types (Vector64, Vector128, Vector256, Vector512) to address issue #120508.
- Replaces many placeholder "To be added." entries with meaningful summaries, type parameter, parameter, and returns descriptions.
- Adds references for constant properties and removes some inheritdoc tags where explicit docs are now provided.
- Introduces new remarks and exception tags, though a few contain grammatical and structural issues.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| xml/System.Runtime.Intrinsics/Vector64.xml | Adds inheritdoc references for constant getters; enhances classification method docs. |
| xml/System.Runtime.Intrinsics/Vector128.xml | Substantial expansion of summaries, parameters, returns, and exceptions; removes some inheritdoc tags. |
| xml/System.Runtime.Intrinsics/Vector256.xml | Mirrors Vector64 constant inheritdoc additions and removes some inheritdoc tags. |
| xml/System.Runtime.Intrinsics/Vector512.xml | Similar updates to Vector256 with inheritdoc additions and cleanup. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gewarren
reviewed
Oct 15, 2025
tannergooding
commented
Oct 15, 2025
Member
Author
|
-- GitHub seems to not like applying bulk suggestions for files with "large diffs". Loading the file causes it to say "the file has changed recently" and forces it to refresh, which then causes the changes to no longer be displayed. |
Member
Author
|
Resolved merge conflicts. This should be ready for review |
gewarren
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves dotnet/runtime#120508