Skip to content

diagnostic: document waithandle keyword#40852

Merged
adegeo merged 5 commits into
dotnet:mainfrom
verdie-g:patch-1
May 18, 2025
Merged

diagnostic: document waithandle keyword#40852
adegeo merged 5 commits into
dotnet:mainfrom
verdie-g:patch-1

Conversation

@verdie-g

@verdie-g verdie-g commented May 11, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@verdie-g
dotnet-trace: document waithandle keyword
f131b03 
This keyword was added for .NET 9+
@verdie-g verdie-g requested review from a team and tommcdon as code owners May 11, 2024 03:06
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 11, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates PR is created by someone from the .NET community. label May 11, 2024
@tommcdon

tommcdon commented May 11, 2024

Copy link
Copy Markdown
Member

This was added on dotnet/diagnostics#4624 however we haven't shipped the updated version of dotnet-trace containing this change. @mikem8361 @hoyosjs - we should merge this doc PR after we ship an updated version of the diagnostic tools.

tommcdon
tommcdon requested changes May 11, 2024
View reviewed changes

@tommcdon tommcdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hold on merging this PR until we have shipped an updated version of dotnet-trace

@verdie-g verdie-g changed the title dotnet-trace: document waithandle keyword diagnostic: document waithandle keyword May 28, 2024
@verdie-g

verdie-g commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

@tommcdon I added some documentation for the event so it would appear in https://learn.microsoft.com/en-us/dotnet/fundamentals/diagnostics/runtime-events.

@BillWagner BillWagner modified the milestones: May 2024, June 2024 Jun 3, 2024
@BillWagner BillWagner modified the milestones: June 2024, July 2024 Jul 1, 2024
@BillWagner

BillWagner commented Aug 1, 2024

Copy link
Copy Markdown
Member

ping @tommcdon Is this still waiting, or is it ready?

@BillWagner BillWagner modified the milestones: July 2024, August 2024 Aug 13, 2024
@verdie-g

verdie-g commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

The change was released in https://github.com/dotnet/diagnostics/releases/tag/v8.0.532401

Add waithandle to clrevents option.

BillWagner
BillWagner reviewed Oct 16, 2024
View reviewed changes
Comment thread docs/fundamentals/diagnostics/runtime-events.md Outdated
@BillWagner

BillWagner commented Oct 16, 2024

Copy link
Copy Markdown
Member

@tommcdon

I looks like this feel through the cracks for final review. You'd marked it as "changes requested". Can you take a look?

BillWagner
BillWagner reviewed Oct 16, 2024
View reviewed changes

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added markdown lint fixes

Comment thread docs/fundamentals/diagnostics/runtime-events.md Outdated
Comment thread docs/fundamentals/diagnostics/runtime-wait-handle-events.md
Comment thread docs/fundamentals/diagnostics/runtime-wait-handle-events.md Outdated
@verdie-g verdie-g requested a review from tommcdon April 12, 2025 22:43
@verdie-g

verdie-g commented Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

@tommcdon could you have have a look at this PR 🙏

tommcdon
tommcdon approved these changes Apr 22, 2025
View reviewed changes

@tommcdon tommcdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@adegeo adegeo merged commit 2c0f4e4 into dotnet:main May 18, 2025
@verdie-g verdie-g mentioned this pull request May 18, 2025
Merged
@verdie-g verdie-g mentioned this pull request May 18, 2025
Merged
@gewarren gewarren mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner left review comments

@tommcdon tommcdon tommcdon approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Milestone

August 2024

Development

Successfully merging this pull request may close these issues.

5 participants

@verdie-g @tommcdon @BillWagner @dotnet-bot @adegeo