Skip to content

Fix moniker syntax spacing and correct misleading wording in back button accessibility docs#3373

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-comments-in-review-thread
Closed

Fix moniker syntax spacing and correct misleading wording in back button accessibility docs#3373
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-comments-in-review-thread

Conversation

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Addresses 8 review comments on PR #3370 — new .NET MAUI 11 back button accessibility label docs introduced inconsistent moniker syntax and two inaccurate prose descriptions.

Moniker syntax (:::::: )

All new moniker blocks used the spaceless form (:::moniker/:::moniker-end), inconsistent with every other block in both files. Fixed in:

  • docs/user-interface/pages/navigationpage.md (two blocks)
  • docs/fundamentals/shell/navigation.md (one block)

Wording corrections

navigationpage.md — The description said the BackButtonAccessibilityLabel property "lives on the destination page—the page the back button returns to", but the example sets it on the page that shows the back button (the current/detail page). Reworded to:

"The label is set with the NavigationPage.BackButtonAccessibilityLabel attached property on the page that displays the back button"

navigation.md — The intro said "The following example sets both properties together", but the sample only sets IconOverride and AccessibilityLabel (not TextOverride). Changed to:

"The following example sets IconOverride and AccessibilityLabel together"


Internal previews

📄 File 🔗 Preview link
docs/fundamentals/shell/navigation.md docs/fundamentals/shell/navigation
docs/user-interface/pages/navigationpage.md docs/user-interface/pages/navigationpage

Copilot AI requested review from Copilot and removed request for Copilot June 11, 2026 20:08
Copilot AI requested review from Copilot and removed request for Copilot June 11, 2026 20:12
Copilot AI changed the title [WIP] Fix code based on review comments Fix moniker syntax spacing and correct misleading wording in back button accessibility docs Jun 11, 2026
Copilot AI requested a review from jfversluis June 11, 2026 20:13
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 257fef1:

✅ Validation status: passed

File Status Preview URL Details
docs/fundamentals/shell/navigation.md ✅Succeeded View (>=net-maui-8.0)
docs/user-interface/pages/navigationpage.md ✅Succeeded View (>=net-maui-8.0)

For more details, please refer to the build report.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

1 similar comment
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 16239bf:

✅ Validation status: passed

File Status Preview URL Details
docs/fundamentals/shell/navigation.md ✅Succeeded View (>=net-maui-8.0)
docs/user-interface/pages/navigationpage.md ✅Succeeded View (>=net-maui-8.0)

For more details, please refer to the build report.

@jfversluis jfversluis marked this pull request as ready for review June 11, 2026 20:19
@jfversluis jfversluis requested a review from a team as a code owner June 11, 2026 20:19
Copilot AI review requested due to automatic review settings June 11, 2026 20:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the .NET MAUI back button accessibility-label documentation to use consistent DocFX moniker directive syntax and to correct two misleading prose statements introduced in the prior PR.

Changes:

  • Normalizes moniker directive formatting to ::: moniker / ::: moniker-end in the affected sections.
  • Corrects NavigationPage.BackButtonAccessibilityLabel wording to match how the attached property is applied in the example.
  • Corrects Shell navigation wording to accurately describe that the sample sets IconOverride + AccessibilityLabel (not TextOverride).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/user-interface/pages/navigationpage.md Fixes moniker directive spacing and clarifies where BackButtonAccessibilityLabel is set.
docs/fundamentals/shell/navigation.md Fixes moniker directive spacing and corrects sample description for back button accessibility label usage.

@jfversluis jfversluis closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants