Fix moniker syntax spacing and correct misleading wording in back button accessibility docs#3373
Fix moniker syntax spacing and correct misleading wording in back button accessibility docs#3373Copilot wants to merge 2 commits into
Conversation
|
Learn Build status updates of commit 257fef1: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
1 similar comment
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 16239bf: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Pull request overview
This PR updates the .NET MAUI back button accessibility-label documentation to use consistent DocFX moniker directive syntax and to correct two misleading prose statements introduced in the prior PR.
Changes:
- Normalizes moniker directive formatting to
::: moniker/::: moniker-endin the affected sections. - Corrects
NavigationPage.BackButtonAccessibilityLabelwording to match how the attached property is applied in the example. - Corrects Shell navigation wording to accurately describe that the sample sets
IconOverride+AccessibilityLabel(notTextOverride).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/user-interface/pages/navigationpage.md | Fixes moniker directive spacing and clarifies where BackButtonAccessibilityLabel is set. |
| docs/fundamentals/shell/navigation.md | Fixes moniker directive spacing and corrects sample description for back button accessibility label usage. |
Addresses 8 review comments on PR #3370 — new
.NET MAUI 11back button accessibility label docs introduced inconsistent moniker syntax and two inaccurate prose descriptions.Moniker syntax (
:::→:::)All new moniker blocks used the spaceless form (
:::moniker/:::moniker-end), inconsistent with every other block in both files. Fixed in:docs/user-interface/pages/navigationpage.md(two blocks)docs/fundamentals/shell/navigation.md(one block)Wording corrections
navigationpage.md— The description said theBackButtonAccessibilityLabelproperty "lives on the destination page—the page the back button returns to", but the example sets it on the page that shows the back button (the current/detail page). Reworded to:navigation.md— The intro said "The following example sets both properties together", but the sample only setsIconOverrideandAccessibilityLabel(notTextOverride). Changed to:Internal previews