fix: resolve local namespace links through xrefs - #11163
Merged
Merged
Conversation
Co-authored-by: Tim Hess <tim.hess@broadcom.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
I agree with prevention over cleanup. Running your Nothing concrete to add on anything missing, but one half-formed thought: your tests are all single-build, and this is the first time local namespace links go through the same xref resolution as external ones. Should it be tested against an external xrefmap.yml (separate site referencing this one)? I'm fine with closing #11012 in favor of this approach |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ec7b1c83-208d-4502-b67f-297527d8c20a
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ec7b1c83-208d-4502-b67f-297527d8c20a
This was referenced Sep 25, 2026
This was referenced Sep 25, 2026
Open
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10588.
Thanks @TimHess for #11012 and the tests. This keeps those test cases but tries a different fix for the namespace link regression from #8588.
Differences
#11012 generates URLs first, then clears links whose UIDs are missing from the metadata.
This PR leaves local namespace
hrefs unset.docfx buildresolves them instead. This only changesmref;apiPageand Markdown keep their current behavior.Trade-offs
#11012 preserves existing
hrefs where possible. But the cleanup can also remove valid links, likeOuter<int>.Inner. The newConstructedNestedTypesKeepUrlstest covers this case.This PR avoids that cleanup. But namespace
hrefs won’t be available right after metadata generation. I’m not sure if any workflows depend on them at that stage.@TimHess, what do you think? Any cases we might be missing?