Skip to content

Bump the xunit group with 1 update - #11107

Merged
vicancy merged 2 commits into
mainfrom
dependabot/nuget/test/main/xunit-388a2e23e1
Aug 13, 2026
Merged

vicancy merged 2 commits into
mainfrom
dependabot/nuget/test/main/xunit-388a2e23e1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Update Verify.Xunit from 31.10.0 to 31.12.5.
  • Preserve the repository's established snapshot workflow after Verify 31.12 changed DiffEngine initialization timing.

Compatibility fix

Normal ci.yml intentionally runs directory snapshots with BuildServerDetector.Detected = false; the manually dispatched snapshot workflow owns accepting and committing snapshot updates (see #9831 and revert commit 464b94716). With Verify 31.12, setting the detector in the module initializer happens too early and is later overwritten by automatic CI detection, causing 494 existing sample snapshots to fail as newly received files.

The fix moves the same explicit detector assignment into the SamplesTest constructor, after Verify/DiffEngine initialization. It preserves the existing policy without changing product output or committing mass snapshot churn.

Validation

  • The original SamplesTest.CSharp failure is resolved without updating verified snapshots.
  • Full Windows, macOS, and Ubuntu CI passes.
  • Lint, Codecov, CLA, and Percy pass.

Bumps Verify.Xunit from 31.10.0 to 31.12.5

---
updated-dependencies:
- dependency-name: Verify.Xunit
  dependency-version: 31.12.5
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: xunit
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Aug 13, 2026
@github-actions
github-actions Bot enabled auto-merge (squash) August 13, 2026 08:27
DiffEngine 18.4 scopes BuildServerDetector overrides with AsyncLocal, so the module initializer value no longer reaches xUnit tests. Apply the override when SamplesTest is constructed instead.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@vicancy vicancy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated Verify.Xunit 31.12 compatibility with the repository's established snapshot workflow; no product snapshots are changed and all checks pass.

@vicancy
vicancy merged commit d35f5a5 into main Aug 13, 2026
10 checks passed
@vicancy
vicancy deleted the dependabot/nuget/test/main/xunit-388a2e23e1 branch August 13, 2026 09:28
This was referenced Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .net code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant