Skip to content

[Bug] Various layout breaks in latest release #11153

Description

@bkoelman

Describe the bug

The latest release (v2.80.1) breaks the layout of our API documentation in various ways, ranging from incorrect vertical whitespace to broken indents.

We've been using a custom build (based on v2.78.4 plus #10859 and #10966) since the start of this year, which rendered properly. Recent changes (potentially #11143) broke it again.

To Reproduce
Steps to reproduce the behavior:

  1. Clone https://github.com/json-api-dotnet/JsonApiDotNetCore
  2. docker compose up --detach --wait (requires a docker runtime, such as Docker Desktop)
  3. git checkout e87afb8aa76df5bafc14bd2e6751cbac5c7351b5 (this is the current master branch)
  4. cd docs
  5. ./build-dev.ps1 -NoOpen, press Enter at the end to stop the webserver
  6. Copy the contents of _site to a local directory named before
  7. git checkout docfx-on-nuget
  8. ./build-dev.ps1 -NoOpen, press Enter at the end to stop the webserver
  9. Copy the contents of _site to a local directory named after
  10. Use a diff tool to compare the contents of the before and after directories

Note: if you want to diff against the latest master, point to the local docfx binary before running build-dev.ps1, as shown here.

Tip: for an easy visual diff, open https://www.jsonapi.net/api/index.html in one browser tab, then omit the -NoOpen switch so the built docs are opened on another browser tab.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions