This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Ignore slow tail calls instead failing the compilation for them#8252
Merged
jkotas merged 1 commit intodotnet:masterfrom Aug 4, 2020
jkotas:tailcallhelpers
Merged
Ignore slow tail calls instead failing the compilation for them#8252jkotas merged 1 commit intodotnet:masterfrom jkotas:tailcallhelpers
jkotas merged 1 commit intodotnet:masterfrom
jkotas:tailcallhelpers
Conversation
Member
Author
|
This restores CoreRT behavior to what it was before #8122 |
MichalStrehovsky
approved these changes
Aug 4, 2020
| { | ||
| // Slow tailcalls are not supported yet | ||
| // https://github.com/dotnet/runtime/issues/35423 | ||
| #if READYTORUN |
Member
There was a problem hiding this comment.
Interesting - if this is reachable in READYTORUN, throwing a NotImplemented here tears down the process because only some specific exceptions are catchable/recoverable (type system exceptions or RequiresRuntimeJitException).
Member
Author
There was a problem hiding this comment.
cc @trylek Do we see crossgen2 tests failing on this? We may want to change this to RequiresRuntimeJitException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8251