Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Port Encoding.GetEncoding(int) changes from CoreCLR#1726

Merged
jkotas merged 1 commit into
dotnet:masterfrom
justinvp:encoding_getencoding
Aug 25, 2016
Merged

Port Encoding.GetEncoding(int) changes from CoreCLR#1726
jkotas merged 1 commit into
dotnet:masterfrom
justinvp:encoding_getencoding

Conversation

@justinvp

@justinvp justinvp commented Aug 25, 2016

Copy link
Copy Markdown
Contributor

Port dotnet/coreclr#6907 from CoreCLR.

Remove EncodingCache and cache UTF32BE in a static field.

@MichalStrehovsky

Copy link
Copy Markdown
Member

We'll only be able to get rid of the TODO once CppCodegen can do interface calls, if my comment from the February pull request is right (I did constrained calls a while ago). We're getting closer, but we're not there yet.

@jkotas

jkotas commented Aug 25, 2016

Copy link
Copy Markdown
Member

We'll only be able to get rid of the TODO once CppCodegen

The change is getting rid of the unifier hashtable that contains the constrained calls on this codepath, so it should be fine to remote the TODO on this codepath.

However, it exposed a different problem in CppCodeGen. There is a problem with string literals mangling: __load_string_literal("!"#$%&*;<=>@[]^_{|}");`. The quote inside the string has to be prefixed with``.

@jkotas

jkotas commented Aug 25, 2016

Copy link
Copy Markdown
Member

@justinvp Could you please add the ifdef & TODO back? We will look at the CppCodeGen break separately.

Port dotnet/coreclr#6907 from CoreCLR.

Remove EncodingCache and cache UTF32BE in a static field.
@justinvp

Copy link
Copy Markdown
Contributor Author

Could you please add the ifdef & TODO back?

@jkotas, done.

@jkotas jkotas merged commit 773be82 into dotnet:master Aug 25, 2016
@jkotas

jkotas commented Aug 25, 2016

Copy link
Copy Markdown
Member

Thanks!

@justinvp justinvp deleted the encoding_getencoding branch August 25, 2016 21:50
@justinvp

Copy link
Copy Markdown
Contributor Author

FYI, I opened #1727 about the string literal issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants