Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/3.1] Add tests for deserializing multi-level subclasses of native collections#42097

Merged
wtgodbe merged 2 commits into
dotnet:release/3.1from
layomia:derived_types_3_1
Oct 30, 2019
Merged

[release/3.1] Add tests for deserializing multi-level subclasses of native collections#42097
wtgodbe merged 2 commits into
dotnet:release/3.1from
layomia:derived_types_3_1

Conversation

@layomia

@layomia layomia commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

Verifies https://github.com/dotnet/corefx/issues/41427 is fixed for 3.1.

Description

This PR adds tests to ensure that the serializer supports (de)serialization of multi-level subclasses of native collections. The fix was added in #41523.
These tests will be included in master as part of #41977.

Customer Impact

Validation that https://github.com/dotnet/corefx/issues/41427 is fixed for 3.1.

Regression?

No.

Risk

Tests only.

@layomia layomia added this to the 3.1 milestone Oct 24, 2019
@layomia layomia self-assigned this Oct 24, 2019
@ahsonkhan ahsonkhan added the test enhancement Improvements of test source code label Oct 24, 2019
Comment thread src/System.Text.Json/tests/Serialization/Value.ReadTests.GenericCollections.cs Outdated
@danmoseley

Copy link
Copy Markdown

@wtgodbe is branch open to merge this? If so let's merge, it's just tests.

@wtgodbe

wtgodbe commented Oct 30, 2019

Copy link
Copy Markdown
Member

Yep, I just merged the branding update so we are open for business

@wtgodbe wtgodbe merged commit d29d1bf into dotnet:release/3.1 Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants