This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Improve JsonSerializer support for derived types#40654
Merged
Merged
Conversation
steveharter
reviewed
Aug 29, 2019
steveharter
reviewed
Aug 29, 2019
steveharter
reviewed
Aug 29, 2019
steveharter
approved these changes
Aug 29, 2019
steveharter
left a comment
steveharter
left a comment
Contributor
There was a problem hiding this comment.
Other than some comment suggestions, LGTM.
Contributor
Author
|
Will update comments in a follow up PR for https://github.com/dotnet/corefx/issues/40370 to avoid CI restart. |
Contributor
Author
|
This PR addresses https://github.com/dotnet/corefx/issues/41242. |
layomia
added a commit
to layomia/corefx
that referenced
this pull request
Oct 3, 2019
layomia
added a commit
that referenced
this pull request
Oct 4, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically,
IList(i.e populating directly, without using a converter), check whether the runtime type is assignable toIList, not the declared type.This fixes https://github.com/dotnet/corefx/issues/40597.
NotSupportedExceptionon deserialization of implementing types that don't have default constructors. This prevents aNullReferenceExceptionwhen we try to create the instance.NotSupportedExceptionon deserialization (because abstract types have no default constructor).System.Collections.ObjectModelin tests.Todo: audit behavior of collections in
System.Collections.Specialized(https://github.com/dotnet/corefx/issues/40370), andSystem.Collections.Concurrent(https://github.com/dotnet/corefx/issues/40657).