Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

improve test filter for bogus VPN IPv6 link local addresses#33995

Merged
geoffkizer merged 1 commit into
dotnet:masterfrom
geoffkizer:fixvpntestissue2
Dec 12, 2018
Merged

improve test filter for bogus VPN IPv6 link local addresses#33995
geoffkizer merged 1 commit into
dotnet:masterfrom
geoffkizer:fixvpntestissue2

Conversation

@geoffkizer

@geoffkizer geoffkizer commented Dec 11, 2018

Copy link
Copy Markdown

We already filter these out. Make the logic catch more cases, e.g. "PANGP Virtual Ethernet Adapter #3" (which is what I'm seeing on my machine now).

Fixes #32493

@dotnet/ncl @stephentoub

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffkizer

Copy link
Copy Markdown
Author

@dotnet-bot test this please

1 similar comment
@geoffkizer

Copy link
Copy Markdown
Author

@dotnet-bot test this please

@davidsh davidsh added this to the 3.0 milestone Dec 12, 2018
@geoffkizer

Copy link
Copy Markdown
Author

@dotnet-bot test windows x64 debug build

@geoffkizer geoffkizer merged commit f66e411 into dotnet:master Dec 12, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
improve test filter for bogus VPN IPv6 link local addresses

Commit migrated from dotnet/corefx@f66e411
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants