Reflection: Add test verifying ParameterInfo.DefaultValue doesn't throw for optional DateTime parameter#29533
Conversation
stakx
changed the title
|
@dotnet-bot test this please |
|
@dotnet-bot test UWP CoreCLR x64 Debug Build please |
|
Just verified Project N already has this behavior so no extra work needed there. |
|
This PR should proceed. (Project N is a separate implementation of the framework for UWP. Changes in Reflection behavior made in CoreCLR often have to be made separately there which is why I went and checked.) |
|
@atsushikan - sorry for the newbie question but I have been having a hard time working out why tests are failing. Is this because given this commit, the CI server will pull a previous version of CoreCLR that doesn't have the necessary changes yet? |
stakx
changed the title
|
Looks like the CoreCLR update is still being pushed along the side of the road. You should be able to monitor this PR: #29561 |
|
@dotnet-bot test this please |
|
not sure how it was passing all jobs (except for only OSX) before? |
@kasper3 - Why, should it not have passed? (I'm still learning the ropes regarding the whole build & CI setup here, so there's a lot I don't understand yet. There were test failures reported for OSX in the Windows checks, even though the OSX build didn't succeed at all for a probably unrelated reason, so I've retriggered all checks to try to understand whether that's simply some caching problem or an actual issue with this PR.) |
|
I thought CoreCLR package update PR was merged after @atsushikan's last comment, which means the test validating that change shouldn't pass if that is what it is supposed to validate? |
|
@kasper3 - I posted a "test this please" right before the one you're seeing now, which updated the status of most checks to green (they were mostly red before that). I deleted that comment shortly before posting the one you're seeing now because I didn't want to spam this thread with repetitive messages. Another lesson learnt... sorry if this caused confusion. (PS: And another lesson for me right here... that bot reacts to that phrase even when not explicitly addressed. I have a lot to learn.) |
…ow for optional DateTime parameter (dotnet/corefx#29533) * Reflection: Test DefaultValue for DateTime params * Exclude DateTime test cases for NETFX Commit migrated from dotnet/corefx@156cbfa
3 participants
This verifies that
ParameterInfo.DefaultValuecan be queried for optional parameters of typeDateTime(andDateTime?just to be sure).The defined test cases can succeed only with a version of CoreCLR that includes these: