RegisterWithDotnetSuggest should not remove "extension" on Linux

[dorssel]

See:

command-line-api/src/System.CommandLine/Builder/CommandLineBuilderExtensions.cs

Line 179 in 209b724

var currentProcessFileNameWithoutExtension = Path.GetFileNameWithoutExtension(currentProcessFullPath);

When building a Linux executable with full assembly name as output file, this removes the last part of the final executable name.

For example, if the executable output is named "Full.Assembly.Name.Linux.Executable", then RegisterWithDotnetSuggest() registers "Full.Assembly.Name.Linux" and completions won't work.

[KalleOlaviNiemitalo]

CliRootCommand.ExecutableName seems to have the same bug, even on the main branch:

command-line-api/src/System.CommandLine/CliRootCommand.cs

Lines 51 to 60 in a0782c8

	/// <summary>
	/// The name of the currently running executable.
	/// </summary>
	public static string ExecutableName
	=> _executableName ??= Path.GetFileNameWithoutExtension(ExecutablePath).Replace(" ", "");
	/// <summary>
	/// The path to the currently running executable.
	/// </summary>
	public static string ExecutablePath => _executablePath ??= Environment.GetCommandLineArgs()[0];

Likewise SuggestionDispatcher.ShellPrefixesToMatch:

command-line-api/src/System.CommandLine.Suggest/SuggestionDispatcher.cs

Lines 185 to 189 in a0782c8

	foreach (var r in registrations)
	{
	var fileNameWithoutExtension = Path.GetFileNameWithoutExtension(r.ExecutablePath);
	yield return fileNameWithoutExtension;

Especially as the extension may have already been deleted from Registration.ExecutablePath by GlobalToolsSuggestionRegistration:

command-line-api/src/System.CommandLine.Suggest/GlobalToolsSuggestionRegistration.cs

Lines 43 to 44 in a0782c8

	return _filesNameWithoutExtensionUnderDotnetProfileTools.Select(p =>
	new Registration(Path.Combine(_nullableToolsShimPath, p)));

But I suppose command-line tools are more commonly named using kebab-case than Dot.Delimited.Titlecase. Except there are versioned names like perl5.36.1.

[KalleOlaviNiemitalo]

RegisterWithDotnetSuggest was deleted in 2.0.0-beta5 so this issue is no longer relevant.