Replace Newtonsoft.Json with System.Text.Json in dotnet-user-secrets by Copilot · Pull Request #65686 · dotnet/aspnetcore

Copilot · 2026-03-06T15:21:59Z

Replaces the Newtonsoft.Json dependency in dotnet-user-secrets with System.Text.Json, using the default STJ character escaping (non-ASCII characters are Unicode-escaped rather than written literally). Consolidates list command tests from SecretManagerTests into the new ListCommandTest, and adds integration tests to cover --json CLI option plumbing and nested JSON flattening behavior.

Description

Removed <Reference Include="Newtonsoft.Json" /> from dotnet-user-secrets.csproj.
Replaced JObject/Formatting.Indented in ListCommand.cs and SecretsStore.cs with JsonSerializer.Serialize using WriteIndented = true and the default STJ encoder (non-ASCII characters are Unicode-escaped).
Extracted the shared JsonSerializerOptions into a static readonly SecretsStore.SerializerOptions field reused by both SecretsStore.Save() and ListCommand.ReportJson().
Added ListCommandTest with unit tests covering JSON output format, non-ASCII Unicode escaping, //BEGIN///END markers, empty store JSON output, non-JSON key = value format, and non-JSON empty store error message.
Consolidated overlapping list tests: removed List_Flattens_Nested_Objects, List_Json, and List_Empty_Secrets_File from SecretManagerTests (all now covered by ListCommandTest unit tests).
Added List_Json_OptionIsWired integration test to SecretManagerTests to verify that the --json CLI option is correctly wired through CommandLineOptions.Parse → ListCommand.Configure → ListCommand.Execute.
Added List_Flattens_Nested_Objects integration test to SecretManagerTests to verify that nested JSON secrets files on disk (e.g., { "AzureAd": { "ClientSecret": "..." } }) are correctly flattened to key:subkey format by SecretsStore.Load().

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…tool Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com>

MichaelSimons · 2026-03-06T15:51:16Z

@dotnet/aspnet-build, please provide feedback on if it is important to preserve Newtonsoft's default behavior of writing non-ASCII characters literally. Should we use the default System.Text.Json escaping? See https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-10-0#minimal-character-escaping for details.

Copilot

Pull request overview

This PR removes the Newtonsoft.Json dependency from dotnet-user-secrets in favor of System.Text.Json, part of a broader SDK migration effort (dotnet/sdk#53287). The output format is preserved by using WriteIndented = true and JavaScriptEncoder.UnsafeRelaxedJsonEscaping to match Newtonsoft's default behavior of emitting non-ASCII characters literally.

Changes:

ListCommand.cs and SecretsStore.cs replace JObject/Formatting.Indented with JsonSerializer.Serialize using equivalent options.
dotnet-user-secrets.csproj removes the <Reference Include="Newtonsoft.Json" /> item.
ListCommandTest.cs adds unit tests covering JSON format, non-ASCII preservation, //BEGIN///END markers, and empty store output.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`src/Internal/ListCommand.cs`	Replaces `JObject` + Newtonsoft formatting with `JsonSerializer` using `UnsafeRelaxedJsonEscaping`
`src/Internal/SecretsStore.cs`	Replaces `JObject` build loop and `Newtonsoft.Json.Linq` with direct `JsonSerializer.Serialize(_secrets, options)`
`src/dotnet-user-secrets.csproj`	Removes the `Newtonsoft.Json` framework reference
`test/ListCommandTest.cs`	Adds new unit tests for the `--json` output format to guard against regressions

…s static field Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com>

MichaelSimons · 2026-03-18T13:31:31Z

@wtgodbe - Can you take a look at this? Also would like feedback on #65686 (comment). TIA

halter73 · 2026-03-24T20:56:03Z

please provide feedback on if it is important to preserve Newtonsoft's default behavior of writing non-ASCII characters literally. Should we use the default System.Text.Json escaping

I think the default System.Text.Json escaping should be fine. We usually use S.T.J to read these secrets via a JsonConfigurationSource.

…CII characters Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/48edeec7-7ad3-4117-ba13-1fcb361f202f

…ndTest Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/c4d3cc42-9115-4247-afd0-515bbd2bcfaf

MichaelSimons · 2026-03-24T21:54:40Z

I think the default System.Text.Json escaping should be fine. We usually use S.T.J to read these secrets via a JsonConfigurationSource.

Done in 66f8e89.

I also noticed an opportunity to consolidate the list command tests which was handled in 59d29fe

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

…on plumbing Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/10b33337-7f61-4287-a7c5-84cb4e85797a

…re.Load() disk reading Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/f9992d14-6c0c-41cf-baa1-e0da01e46226

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

79c2b41

Copilot AI assigned Copilot and MichaelSimons Mar 6, 2026

Copilot started work on behalf of MichaelSimons March 6, 2026 15:22 View session

github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 6, 2026

Replace Newtonsoft.Json with System.Text.Json in dotnet-user-secrets …

57bd09a

…tool Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Replace Newtonsoft.Json with System.Text.Json in dotnet-user-secrets~~ Replace Newtonsoft.Json with System.Text.Json in dotnet-user-secrets Mar 6, 2026

Copilot finished work on behalf of MichaelSimons March 6, 2026 15:43

MichaelSimons marked this pull request as ready for review March 9, 2026 14:23

Copilot AI review requested due to automatic review settings March 9, 2026 14:23

Copilot started reviewing on behalf of MichaelSimons March 9, 2026 14:23 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

Comment thread src/Tools/dotnet-user-secrets/src/Internal/ListCommand.cs Outdated

Comment thread src/Tools/dotnet-user-secrets/src/Internal/SecretsStore.cs Outdated

Copilot started work on behalf of MichaelSimons March 9, 2026 14:34 View session

Extract shared JsonSerializerOptions to SecretsStore.SerializerOption…

9811cd9

…s static field Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com>

Copilot finished work on behalf of MichaelSimons March 9, 2026 14:42

dotnet-policy-service Bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 16, 2026

Merge branch 'main' into copilot/replace-newtonsoft-json-dependency

40f7f91

MichaelSimons requested a review from a team March 17, 2026 14:13

MichaelSimons mentioned this pull request Mar 18, 2026

Remove Newtonsoft.Json from the .NET SDK installation dotnet/sdk#53287

Open

5 tasks

halter73 approved these changes Mar 24, 2026

View reviewed changes

wtgodbe approved these changes Mar 24, 2026

View reviewed changes

Copilot started work on behalf of MichaelSimons March 24, 2026 21:07 View session

Remove UnsafeRelaxedJsonEscaping, use default STJ escaping for non-AS…

66f8e89

…CII characters Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/48edeec7-7ad3-4117-ba13-1fcb361f202f

Copilot AI requested a review from MichaelSimons March 24, 2026 21:17

Copilot finished work on behalf of MichaelSimons March 24, 2026 21:17

Copilot started work on behalf of MichaelSimons March 24, 2026 21:41 View session

Consolidate list command tests from SecretManagerTests into ListComma…

59d29fe

…ndTest Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/c4d3cc42-9115-4247-afd0-515bbd2bcfaf

Copilot finished work on behalf of MichaelSimons March 24, 2026 21:51

MichaelSimons requested review from Copilot, halter73 and wtgodbe March 24, 2026 21:54

Copilot started reviewing on behalf of MichaelSimons March 24, 2026 21:55 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Comment thread src/Tools/dotnet-user-secrets/test/ListCommandTest.cs

Comment thread src/Tools/dotnet-user-secrets/test/ListCommandTest.cs

Copilot started work on behalf of MichaelSimons March 25, 2026 14:08 View session

Add List_Json_OptionIsWired integration test to cover --json CLI opti…

8ba1aaa

…on plumbing Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/10b33337-7f61-4287-a7c5-84cb4e85797a

Copilot started work on behalf of MichaelSimons March 25, 2026 14:16 View session

Copilot finished work on behalf of MichaelSimons March 25, 2026 14:16

Add List_Flattens_Nested_Objects integration test to cover SecretsSto…

084a745

…re.Load() disk reading Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/f9992d14-6c0c-41cf-baa1-e0da01e46226

Copilot finished work on behalf of MichaelSimons March 25, 2026 14:24

MichaelSimons requested a review from Copilot March 25, 2026 14:28

Copilot started reviewing on behalf of MichaelSimons March 25, 2026 14:28 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread src/Tools/dotnet-user-secrets/src/Internal/SecretsStore.cs

Comment thread src/Tools/dotnet-user-secrets/test/ListCommandTest.cs Outdated

MichaelSimons and others added 2 commits May 5, 2026 09:50

Apply suggestion from @Copilot

4ba58be

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into copilot/replace-newtonsoft-json-dependency

0c389c8

MichaelSimons enabled auto-merge (squash) May 5, 2026 14:52

MichaelSimons merged commit 4b6bdf3 into main May 5, 2026
25 checks passed

MichaelSimons deleted the copilot/replace-newtonsoft-json-dependency branch May 5, 2026 15:56

dotnet-policy-service Bot added this to the 11.0-preview5 milestone May 5, 2026

dotnet-maestro Bot mentioned this pull request May 6, 2026

[main] Source code updates from dotnet/aspnetcore dotnet/dotnet#6464

Merged

This was referenced Jun 4, 2026

Cross-reference ASP.NET Core 11 breaking changes from the .NET 11 overview dotnet/docs#54188

Merged

Document ASP.NET Core breaking changes in .NET 11 dotnet/AspNetCore.Docs#37228

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Newtonsoft.Json with System.Text.Json in dotnet-user-secrets#65686

Replace Newtonsoft.Json with System.Text.Json in dotnet-user-secrets#65686
MichaelSimons merged 10 commits into
mainfrom
copilot/replace-newtonsoft-json-dependency

Copilot AI commented Mar 6, 2026 •

edited

Loading

Uh oh!

MichaelSimons commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

MichaelSimons commented Mar 18, 2026

Uh oh!

halter73 commented Mar 24, 2026

Uh oh!

MichaelSimons commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

MichaelSimons commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

MichaelSimons commented Mar 18, 2026

Uh oh!

halter73 commented Mar 24, 2026

Uh oh!

MichaelSimons commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Mar 6, 2026 •

edited

Loading