Repository navigation
[release/8.0] Fix ResponseCompressionMiddleware tests - #60884
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ResponseCompressionMiddleware tests to account for Fedora41's variable compression sizes by checking that the body length is within a reasonable range.
- Modified test to use an in-range assertion for ContentLength
- Retains the original equality assertion which may lead to conflicting behavior
Comments suppressed due to low confidence (1)
src/Middleware/ResponseCompression/test/ResponseCompressionMiddlewareTest.cs:1327
- The equality assertion conflicts with the new in-range assertion. Consider removing or updating this equality check to avoid failure on Fedora41 where the compression size may vary.
Assert.Equal(expectedBodyLength, response.Content.Headers.ContentLength);
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
|
@wtgodbe @BrennanConroy Is this still an issue for release/8.0? Are we seeing it failing in any recent release/8.0 builds? |
Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Compression size is no longer guaranteed on Fedora41, so instead check that the size is within a reasonable range (+/- 5)
Fixes #59870